Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1796)

Unified Diff: chrome/browser/extensions/browser_event_router.cc

Issue 10911300: Move ExtensionAction from common/ to browser/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: proof of concept Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/browser_event_router.cc
diff --git a/chrome/browser/extensions/browser_event_router.cc b/chrome/browser/extensions/browser_event_router.cc
index af5cf9b53b39d0a1ad37eac855aaf571cc0769d6..6ae745a4f351d851dcbf7585d54115dc214bffe2 100644
--- a/chrome/browser/extensions/browser_event_router.cc
+++ b/chrome/browser/extensions/browser_event_router.cc
@@ -9,6 +9,7 @@
#include "chrome/browser/extensions/api/extension_action/extension_page_actions_api_constants.h"
#include "chrome/browser/extensions/api/tabs/tabs_constants.h"
#include "chrome/browser/extensions/event_names.h"
+#include "chrome/browser/extensions/extension_action.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_system.h"
#include "chrome/browser/extensions/extension_tab_util.h"
@@ -585,13 +586,13 @@ void BrowserEventRouter::ExtensionActionExecuted(
TabContents* tab_contents) {
const char* event_name = NULL;
switch (extension_action.action_type()) {
- case ExtensionAction::TYPE_BROWSER:
+ case Extension::ActionInfo::TYPE_BROWSER:
event_name = "browserAction.onClicked";
break;
- case ExtensionAction::TYPE_PAGE:
+ case Extension::ActionInfo::TYPE_PAGE:
event_name = "pageAction.onClicked";
break;
- case ExtensionAction::TYPE_SCRIPT_BADGE:
+ case Extension::ActionInfo::TYPE_SCRIPT_BADGE:
event_name = "scriptBadge.onClicked";
break;
}

Powered by Google App Engine
This is Rietveld 408576698