Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_pageaction_unittest.cc

Issue 10911300: Move ExtensionAction from common/ to browser/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: proof of concept Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6 6
7 #include "chrome/common/extensions/extension_action.h"
8 #include "chrome/common/extensions/extension_manifest_constants.h" 7 #include "chrome/common/extensions/extension_manifest_constants.h"
9 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
10 9
11 namespace errors = extension_manifest_errors; 10 namespace errors = extension_manifest_errors;
12 11
13 TEST_F(ExtensionManifestTest, PageActionManifestVersion2) { 12 TEST_F(ExtensionManifestTest, PageActionManifestVersion2) {
14 scoped_refptr<extensions::Extension> extension( 13 scoped_refptr<extensions::Extension> extension(
15 LoadAndExpectSuccess("page_action_manifest_version_2.json")); 14 LoadAndExpectSuccess("page_action_manifest_version_2.json"));
16 ASSERT_TRUE(extension.get()); 15 ASSERT_TRUE(extension.get());
17 ASSERT_TRUE(extension->page_action()); 16 ASSERT_TRUE(extension->page_action());
18 17
19 EXPECT_EQ("", extension->page_action()->id()); 18 EXPECT_EQ("", extension->page_action()->id);
20 EXPECT_EQ(0u, extension->page_action()->icon_paths()->size()); 19 EXPECT_EQ("", extension->page_action()->default_icon_path);
21 EXPECT_EQ("", extension->page_action()->GetTitle( 20 EXPECT_EQ("", extension->page_action()->default_title);
22 ExtensionAction::kDefaultTabId)); 21 EXPECT_TRUE(extension->page_action()->default_popup_url.is_empty());
23 EXPECT_FALSE(extension->page_action()->HasPopup(
24 ExtensionAction::kDefaultTabId));
25 22
26 LoadAndExpectError("page_action_manifest_version_2b.json", 23 LoadAndExpectError("page_action_manifest_version_2b.json",
27 errors::kInvalidPageActionPopup); 24 errors::kInvalidPageActionPopup);
28 } 25 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698