chromeos: Stop calling ProfileManager::GetDefaultProfile() from extension event dispatch functions

chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Index: chrome/browser/chromeos/chrome_browser_main_chromeos.cc
diff --git a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
index dbea8c98dfb2f635c74d326debdbae8b47ec7820..b841678bf2de2b621af5714b4d7094dbf3fc77d1 100644
--- a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
+++ b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
@@ -457,10 +457,10 @@ void ChromeBrowserMainPartsChromeos::PostProfileInit() {
   //
   // Initialize the brightness observer so that we'll display an onscreen
   // indication of brightness changes during login.
-  brightness_observer_.reset(new chromeos::BrightnessObserver());
+  brightness_observer_.reset(new chromeos::BrightnessObserver(profile()));

[satorux1, 2012/09/13 00:42:56]

Please write some comment about why these observers need to take profile() and
cache the pointer

[hashimoto, 2012/09/13 01:01:40]

There is already a comment "they use the profile to dispatch extension events"
above.
And I don't think we should add some comment about why we are not using
GetDefaultProfile() since ProfileManager::GetDefaultProfile() is marked as
DEPRECATED in profile_manager.h (even though they allow Chrome OS code to use
it).

Thoughts?

[satorux1, 2012/09/13 01:13:46]

I thought it'd be nice to explain why these observers need to cache the pointer
to the Profile used at this moment (Profile for login), as it's solving a subtle
problem.

   output_observer_.reset(new chromeos::OutputObserver());
-  resume_observer_.reset(new chromeos::ResumeObserver());
-  screen_lock_observer_.reset(new chromeos::ScreenLockObserver());
+  resume_observer_.reset(new chromeos::ResumeObserver(profile()));
+  screen_lock_observer_.reset(new chromeos::ScreenLockObserver(profile()));
   if (chromeos::KioskModeSettings::Get()->IsKioskModeEnabled())
     power_state_override_.reset(new chromeos::PowerStateOverride());