Change the way the ToplevelEventHandler is hooked up. It is now both a pre- and post-target event h…

ui/base/events/event.cc

Index: ui/base/events/event.cc
===================================================================
--- ui/base/events/event.cc	(revision 156300)
+++ ui/base/events/event.cc	(working copy)
@@ -53,6 +53,10 @@
 
 namespace ui {
 
+bool EventCanceledDefaultHandling(const ui::Event& event) {
+  return event.phase() == EP_POSTTARGET && event.result() != ER_UNHANDLED;

[sadrul, 2012/09/12 18:19:33]

Right now, the default handler triggers event if one of the pre-target handlers
return ER_HANDLED. So this check should be !(event.result() & ER_CONSUMED)
(EventDispatcher::ProcessEvent has a comment explaining the current behaviour)

[Ben Goodger (Google), 2012/09/12 18:39:53]

But this function won't even be called if event.result() & ER_CONSUMED, right?

Consumed stops propagation, handled just says "next layer up, don't do the
default thing but keep propagating".

[sadrul, 2012/09/12 18:47:36]

Ah yes. For CONSUMED, this wouldn't be called at all, you are right. I missed in
the comments that this is for post-target handling only.

+}
+
 ////////////////////////////////////////////////////////////////////////////////
 // Event