Chromium Code Reviews| Index: chrome/browser/ui/webui/sync_setup_handler.cc |
| diff --git a/chrome/browser/ui/webui/sync_setup_handler.cc b/chrome/browser/ui/webui/sync_setup_handler.cc |
| index 794cf102678407473d770dc0d5f2261ac38c3bcc..2fca3d0ee4c07f2a386b9162900b0d447143fb59 100644 |
| --- a/chrome/browser/ui/webui/sync_setup_handler.cc |
| +++ b/chrome/browser/ui/webui/sync_setup_handler.cc |
| @@ -285,6 +285,7 @@ void SyncSetupHandler::GetStaticLocalizedValues( |
| static OptionsStringResource resources[] = { |
| { "syncSetupConfigureTitle", IDS_SYNC_SETUP_CONFIGURE_TITLE }, |
|
Nicolas Zea
2012/09/11 12:58:30
is this still used or can it be removed?
kochi
2012/09/11 13:40:12
This is still used for the "Advanced sync configur
|
| + { "syncSetupSpinnerTitle", IDS_SYNC_SETUP_SPINNER_TITLE }, |
| { "syncSetupTimeoutTitle", IDS_SYNC_SETUP_TIME_OUT_TITLE }, |
| { "syncSetupTimeoutContent", IDS_SYNC_SETUP_TIME_OUT_CONTENT }, |
| { "cannotBeBlank", IDS_SYNC_CANNOT_BE_BLANK }, |
| @@ -590,8 +591,6 @@ bool SyncSetupHandler::PrepareSyncSetup() { |
| return true; |
| } |
| -// TODO(kochi): Handle error conditions (timeout, other failures). |
| -// http://crbug.com/128692 |
| void SyncSetupHandler::DisplaySpinner() { |
| configuring_sync_ = true; |
| StringValue page("spinner"); |