Support for ntp promo bubble.

chrome/browser/ui/webui/ntp/new_tab_page_handler.cc

Index: chrome/browser/ui/webui/ntp/new_tab_page_handler.cc
===================================================================
--- chrome/browser/ui/webui/ntp/new_tab_page_handler.cc	(revision 155564)
+++ chrome/browser/ui/webui/ntp/new_tab_page_handler.cc	(working copy)
@@ -51,18 +51,24 @@
         shown_page_type, kHistogramEnumerationMax);
   }
 
-  web_ui()->RegisterMessageCallback("closeNotificationPromo",
-      base::Bind(&NewTabPageHandler::HandleCloseNotificationPromo,
+  web_ui()->RegisterMessageCallback("notificationPromoClosed",
+      base::Bind(&NewTabPageHandler::HandleNotificationPromoClosed,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback("notificationPromoViewed",
       base::Bind(&NewTabPageHandler::HandleNotificationPromoViewed,
                  base::Unretained(this)));
+  web_ui()->RegisterMessageCallback("bubblePromoClosed",
+      base::Bind(&NewTabPageHandler::HandleBubblePromoClosed,
+                 base::Unretained(this)));
+  web_ui()->RegisterMessageCallback("bubblePromoViewed",
+      base::Bind(&NewTabPageHandler::HandleBubblePromoViewed,
+                 base::Unretained(this)));
   web_ui()->RegisterMessageCallback("pageSelected",
       base::Bind(&NewTabPageHandler::HandlePageSelected,
                  base::Unretained(this)));
 }
 
-void NewTabPageHandler::HandleCloseNotificationPromo(const ListValue* args) {
+void NewTabPageHandler::HandleNotificationPromoClosed(const ListValue* args) {
   NotificationPromo::HandleClosed(Profile::FromWebUI(web_ui()),
                                   NotificationPromo::NTP_NOTIFICATION_PROMO);
   Notify(chrome::NOTIFICATION_PROMO_RESOURCE_STATE_CHANGED);
@@ -70,11 +76,24 @@
 
 void NewTabPageHandler::HandleNotificationPromoViewed(const ListValue* args) {
   if (NotificationPromo::HandleViewed(Profile::FromWebUI(web_ui()),
-        NotificationPromo::NTP_NOTIFICATION_PROMO)) {
+      NotificationPromo::NTP_NOTIFICATION_PROMO)) {

[Dan Beam, 2012/09/11 20:32:21]

I meant more spaces :)

[achuithb, 2012/09/11 20:37:05]

Can't do it, doesn't fit if I line it up with the first arg :/ 

Moved both args to the second line, and that doesn't fit either. The only other
option is to have each arg on a separate line. It seems wasteful, but I can do
that if you prefer. The way I have it is acceptable, I believe.

[Dan Beam, 2012/09/11 20:51:22]

I meant +4 \s, let me just show you ;)

  if (NotificationPromo::HandleViewed(Profile::FromWebUI(web_ui()),
          NotificationPromo::NTP_NOTIFICATION_PROMO)) {

[achuithb, 2012/09/11 21:27:46]

I've managed to do this now.

     Notify(chrome::NOTIFICATION_PROMO_RESOURCE_STATE_CHANGED);
   }
 }
 
+void NewTabPageHandler::HandleBubblePromoClosed(const ListValue* args) {
+  NotificationPromo::HandleClosed(Profile::FromWebUI(web_ui()),
+                                  NotificationPromo::NTP_BUBBLE_PROMO);
+  Notify(chrome::NOTIFICATION_PROMO_RESOURCE_STATE_CHANGED);
+}
+
+void NewTabPageHandler::HandleBubblePromoViewed(const ListValue* args) {
+  if (NotificationPromo::HandleViewed(Profile::FromWebUI(web_ui()),
+                                      NotificationPromo::NTP_BUBBLE_PROMO)) {
+    Notify(chrome::NOTIFICATION_PROMO_RESOURCE_STATE_CHANGED);
+  }
+}
+
 void NewTabPageHandler::HandlePageSelected(const ListValue* args) {
   page_switch_count_++;