Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: chrome/browser/ui/views/infobars/confirm_infobar.h

Issue 10911169: Setup field trial for one-click signin inforbar. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Steve's review comments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/infobars/confirm_infobar.h
diff --git a/chrome/browser/ui/views/infobars/confirm_infobar.h b/chrome/browser/ui/views/infobars/confirm_infobar.h
index 35835470496ad5170dc3883de0cc1f2c9d9e2ab2..02cf70e302934cdb75f91d1dff1e280c0e23b304 100644
--- a/chrome/browser/ui/views/infobars/confirm_infobar.h
+++ b/chrome/browser/ui/views/infobars/confirm_infobar.h
@@ -25,9 +25,11 @@ class ConfirmInfoBar : public InfoBarView,
public:
ConfirmInfoBar(InfoBarTabHelper* owner, ConfirmInfoBarDelegate* delegate);
- private:
+ protected:
Peter Kasting 2012/09/11 23:02:07 Nit: I suggest adding a comment like: // TODO(rog
Roger Tawa OOO till Jul 10th 2012/09/12 15:07:14 Done.
virtual ~ConfirmInfoBar();
+ views::TextButton* ok_button() { return ok_button_; }
+
// InfoBarView:
Peter Kasting 2012/09/11 23:02:07 Nit: Looks like only the destructor, ok_button(),
Roger Tawa OOO till Jul 10th 2012/09/12 15:07:14 Right, but I didn't want to mess up the declaratio
Peter Kasting 2012/09/12 17:21:24 It doesn't matter much if we expect to rip this ba
virtual void Layout() OVERRIDE;
virtual void ViewHierarchyChanged(bool is_add,
@@ -40,6 +42,7 @@ class ConfirmInfoBar : public InfoBarView,
// views::LinkListener:
virtual void LinkClicked(views::Link* source, int event_flags) OVERRIDE;
+ private:
ConfirmInfoBarDelegate* GetDelegate();
views::Label* label_;

Powered by Google App Engine
This is Rietveld 408576698