chrome/browser/extensions/api/webstore_private/webstore_private_api.h - Issue 10911158: Pass on download or installation errors from WebstoreInstaller to the CompleteInstall function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.h

Issue 10911158: Pass on download or installation errors from WebstoreInstaller to the CompleteInstall function. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix test Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/webstore_private/webstore_private_api.cc » ('j') | chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.h

diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.h b/chrome/browser/extensions/api/webstore_private/webstore_private_api.h

index 048cad4013f12e137166e1d5316904c2c4272e37..c69afddf361d4ba48c9ad4c41ea7651a1a408902 100644

--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.h

+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.h

@@ -149,10 +149,16 @@ class BeginInstallWithManifestFunction

scoped_ptr<ExtensionInstallPrompt> install_prompt_;

};

-class CompleteInstallFunction : public SyncExtensionFunction {

+class CompleteInstallFunction

+ : public AsyncExtensionFunction,

+ public WebstoreInstaller::Delegate {

public:

DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.completeInstall");

+ // WebstoreInstaller::Delegate:

+ virtual void OnExtensionInstallSuccess(const std::string& id) OVERRIDE;

+ virtual void OnExtensionInstallFailure(const std::string& id,

+ const std::string& error) OVERRIDE;

protected:

virtual ~CompleteInstallFunction() {}