URLRequestHttpJob::StartTransaction should honour network delegate.

net/url_request/url_request_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shlobj.h>
 #endif
@@ skipping 678 matching lines @@
     MessageLoop::current()->Run();
 
     EXPECT_EQ(URLRequestStatus::FAILED, r.status().status());
     EXPECT_EQ(ERR_EMPTY_RESPONSE, r.status().error());
     EXPECT_EQ(1, network_delegate.created_requests());
     EXPECT_EQ(0, network_delegate.destroyed_requests());
   }
   EXPECT_EQ(1, network_delegate.destroyed_requests());
 }
 
+// Tests that the network delegate can cancel a request asynchronously in
+// various stages of the request.
+TEST_F(URLRequestTestHTTP, NetworkDelegateCancelRequestAsynchronously) {
+  ASSERT_TRUE(test_server_.Start());
+
+  static const BlockingNetworkDelegateWithManualCallback::State
+      blocking_states[] = {
+    //BlockingNetworkDelegateWithManualCallback::ON_BEFORE_URL_REQUEST,

[vabr (Chromium), 2012/09/10 15:32:59]

I'm not sure why, but if blocking ON_BEFORE_URL_REQUEST then the request gets
not cancelled. Any ideas?

+    BlockingNetworkDelegateWithManualCallback::ON_BEFORE_SEND_HEADERS,
+    BlockingNetworkDelegateWithManualCallback::ON_HEADERS_RECEIVED
+  };
+
+  for (size_t i = 0; i < arraysize(blocking_states); ++i) {
+    TestDelegate d;
+    BlockingNetworkDelegateWithManualCallback network_delegate;
+    network_delegate.BlockOn(blocking_states[i]);
+
+    TestURLRequestContextWithProxy context(
+        test_server_.host_port_pair().ToString(),
+        &network_delegate);
+
+    {
+      URLRequest r(test_server_.GetURL(""), &d, &context);
+
+      r.Start();
+      network_delegate.WaitForState(blocking_states[i]);
+      network_delegate.DoCallback(ERR_BLOCKED_BY_CLIENT);
+
+      EXPECT_EQ(URLRequestStatus::FAILED, r.status().status());
+      EXPECT_EQ(ERR_BLOCKED_BY_CLIENT, r.status().error());
+      EXPECT_EQ(1, network_delegate.created_requests());
+      EXPECT_EQ(0, network_delegate.destroyed_requests());
+    }
+    EXPECT_EQ(1, network_delegate.destroyed_requests());
+  }
+}
+
 // Tests that the network delegate can block and redirect a request to a new
 // URL.
 TEST_F(URLRequestTestHTTP, NetworkDelegateRedirectRequest) {
   ASSERT_TRUE(test_server_.Start());
 
   TestDelegate d;
   BlockingNetworkDelegate network_delegate;
   GURL redirect_url(test_server_.GetURL("simple.html"));
   network_delegate.set_redirect_url(redirect_url);
 
@@ skipping 3972 matching lines @@
   req.SetExtraRequestHeaders(headers);
   req.Start();
   MessageLoop::current()->Run();
   // If the net tests are being run with ChromeFrame then we need to allow for
   // the 'chromeframe' suffix which is added to the user agent before the
   // closing parentheses.
   EXPECT_TRUE(StartsWithASCII(d.data_received(), "Lynx (textmode", true));
 }
 
 }  // namespace net