Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: chrome/browser/favicon/favicon_handler.h

Issue 10911149: Cleanup FaviconHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_handler.cc » ('j') | chrome/browser/favicon/favicon_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_handler.h
diff --git a/chrome/browser/favicon/favicon_handler.h b/chrome/browser/favicon/favicon_handler.h
index 721a49ab4091c03f2dd4b874317bc991b95d06e9..c24c2d63b46363b3c0f91fc460bf7e5710e693a3 100644
--- a/chrome/browser/favicon/favicon_handler.h
+++ b/chrome/browser/favicon/favicon_handler.h
@@ -115,8 +115,8 @@ class FaviconHandler {
void OnDidDownloadFavicon(int id,
rjkroege 2012/09/10 15:57:08 nit: My preference would be for this to have a com
pkotwicz 2012/09/10 17:34:38 Done.
const GURL& image_url,
bool errored,
- const gfx::Image& image,
- float score);
+ int requested_size,
+ const std::vector<SkBitmap>& bitmaps);
// For testing.
const std::deque<FaviconURL>& image_urls() const { return image_urls_; }
@@ -245,11 +245,6 @@ class FaviconHandler {
const std::vector<history::FaviconBitmapResult>& favicon_bitmap_results);
void UpdateFavicon(content::NavigationEntry* entry, const gfx::Image* image);
- // If the image is not already at its preferred size, scales the image such
- // that either the width and/or height == gfx::kFaviconSize. Does nothing if
- // the image is empty.
- gfx::Image ResizeFaviconIfNeeded(const gfx::Image& image);
-
void FetchFaviconInternal();
// Return the current candidate if any.
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_handler.cc » ('j') | chrome/browser/favicon/favicon_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698