Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3466)

Unified Diff: chrome/browser/favicon/favicon_handler.h

Issue 10911149: Cleanup FaviconHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_handler.cc » ('j') | chrome/browser/favicon/favicon_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_handler.h
diff --git a/chrome/browser/favicon/favicon_handler.h b/chrome/browser/favicon/favicon_handler.h
index 721a49ab4091c03f2dd4b874317bc991b95d06e9..e32bc46e840ecfcaa3c0f17ce3bce3dd5e528025 100644
--- a/chrome/browser/favicon/favicon_handler.h
+++ b/chrome/browser/favicon/favicon_handler.h
@@ -112,6 +112,10 @@ class FaviconHandler {
// history / download service.
void ProcessCurrentUrl();
+ // Called with the results from the download initiated via
+ // FaviconHandlerDelegate::StartDownload().
+ // |image| is resized to how it should appear in the UI and be stored in
rjkroege 2012/09/07 16:45:46 Where is the image resized?
+ // history.
void OnDidDownloadFavicon(int id,
const GURL& image_url,
bool errored,
@@ -245,11 +249,6 @@ class FaviconHandler {
const std::vector<history::FaviconBitmapResult>& favicon_bitmap_results);
void UpdateFavicon(content::NavigationEntry* entry, const gfx::Image* image);
- // If the image is not already at its preferred size, scales the image such
- // that either the width and/or height == gfx::kFaviconSize. Does nothing if
- // the image is empty.
- gfx::Image ResizeFaviconIfNeeded(const gfx::Image& image);
-
void FetchFaviconInternal();
// Return the current candidate if any.
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_handler.cc » ('j') | chrome/browser/favicon/favicon_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698