Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Side by Side Diff: chrome/browser/favicon/favicon_tab_helper.h

Issue 10911149: Cleanup FaviconHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_
6 #define CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_ 6 #define CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 private: 84 private:
85 // content::WebContentsObserver overrides. 85 // content::WebContentsObserver overrides.
86 virtual void NavigateToPendingEntry( 86 virtual void NavigateToPendingEntry(
87 const GURL& url, 87 const GURL& url,
88 content::NavigationController::ReloadType reload_type) OVERRIDE; 88 content::NavigationController::ReloadType reload_type) OVERRIDE;
89 virtual void DidNavigateMainFrame( 89 virtual void DidNavigateMainFrame(
90 const content::LoadCommittedDetails& details, 90 const content::LoadCommittedDetails& details,
91 const content::FrameNavigateParams& params) OVERRIDE; 91 const content::FrameNavigateParams& params) OVERRIDE;
92 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; 92 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
93 93
94 // Message handler for IconHostMsg_DidDownloadFavicon.
94 void OnDidDownloadFavicon(int id, 95 void OnDidDownloadFavicon(int id,
95 const GURL& image_url, 96 const GURL& image_url,
96 bool errored, 97 bool errored,
97 int requested_size, 98 int requested_size,
98 const std::vector<SkBitmap>& bitmaps); 99 const std::vector<SkBitmap>& bitmaps);
99 100
100 Profile* profile_; 101 Profile* profile_;
101 102
102 scoped_ptr<FaviconHandler> favicon_handler_; 103 scoped_ptr<FaviconHandler> favicon_handler_;
103 104
104 // Handles downloading touchicons. It is NULL if 105 // Handles downloading touchicons. It is NULL if
105 // browser_defaults::kEnableTouchIcon is false. 106 // browser_defaults::kEnableTouchIcon is false.
106 scoped_ptr<FaviconHandler> touch_icon_handler_; 107 scoped_ptr<FaviconHandler> touch_icon_handler_;
107 108
108 DISALLOW_COPY_AND_ASSIGN(FaviconTabHelper); 109 DISALLOW_COPY_AND_ASSIGN(FaviconTabHelper);
109 }; 110 };
110 111
111 #endif // CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_ 112 #endif // CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/favicon/favicon_handler_unittest.cc ('k') | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698