Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: sync/notifier/non_blocking_invalidator.cc

Issue 10911084: Implement Invalidator::Acknowledge (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Restart test + more cleanup Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/notifier/non_blocking_invalidator.h" 5 #include "sync/notifier/non_blocking_invalidator.h"
6 6
7 #include <cstddef> 7 #include <cstddef>
8 8
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 12 matching lines...) Expand all
23 public InvalidationHandler { 23 public InvalidationHandler {
24 public: 24 public:
25 // Called on parent thread. |delegate_observer| should be 25 // Called on parent thread. |delegate_observer| should be
26 // initialized. 26 // initialized.
27 explicit Core( 27 explicit Core(
28 const WeakHandle<InvalidationHandler>& delegate_observer); 28 const WeakHandle<InvalidationHandler>& delegate_observer);
29 29
30 // Helpers called on I/O thread. 30 // Helpers called on I/O thread.
31 void Initialize( 31 void Initialize(
32 const notifier::NotifierOptions& notifier_options, 32 const notifier::NotifierOptions& notifier_options,
33 const InvalidationVersionMap& initial_max_invalidation_versions, 33 const InvalidationStateMap& initial_invalidation_state_map,
34 const std::string& invalidation_bootstrap_data, 34 const std::string& invalidation_bootstrap_data,
35 const WeakHandle<InvalidationStateTracker>& invalidation_state_tracker, 35 const WeakHandle<InvalidationStateTracker>& invalidation_state_tracker,
36 const std::string& client_info); 36 const std::string& client_info);
37 void Teardown(); 37 void Teardown();
38 void UpdateRegisteredIds(const ObjectIdSet& ids); 38 void UpdateRegisteredIds(const ObjectIdSet& ids);
39 void Acknowledge(const invalidation::ObjectId& id,
40 const AckHandle& ack_handle);
39 void SetUniqueId(const std::string& unique_id); 41 void SetUniqueId(const std::string& unique_id);
40 void SetStateDeprecated(const std::string& state); 42 void SetStateDeprecated(const std::string& state);
41 void UpdateCredentials(const std::string& email, const std::string& token); 43 void UpdateCredentials(const std::string& email, const std::string& token);
42 44
43 // InvalidationHandler implementation (all called on I/O thread by 45 // InvalidationHandler implementation (all called on I/O thread by
44 // InvalidationNotifier). 46 // InvalidationNotifier).
45 virtual void OnInvalidatorStateChange(InvalidatorState reason) OVERRIDE; 47 virtual void OnInvalidatorStateChange(InvalidatorState reason) OVERRIDE;
46 virtual void OnIncomingInvalidation( 48 virtual void OnIncomingInvalidation(
47 const ObjectIdInvalidationMap& invalidation_map, 49 const ObjectIdInvalidationMap& invalidation_map,
48 IncomingInvalidationSource source) OVERRIDE; 50 IncomingInvalidationSource source) OVERRIDE;
(...skipping 16 matching lines...) Expand all
65 const WeakHandle<InvalidationHandler>& delegate_observer) 67 const WeakHandle<InvalidationHandler>& delegate_observer)
66 : delegate_observer_(delegate_observer) { 68 : delegate_observer_(delegate_observer) {
67 DCHECK(delegate_observer_.IsInitialized()); 69 DCHECK(delegate_observer_.IsInitialized());
68 } 70 }
69 71
70 NonBlockingInvalidator::Core::~Core() { 72 NonBlockingInvalidator::Core::~Core() {
71 } 73 }
72 74
73 void NonBlockingInvalidator::Core::Initialize( 75 void NonBlockingInvalidator::Core::Initialize(
74 const notifier::NotifierOptions& notifier_options, 76 const notifier::NotifierOptions& notifier_options,
75 const InvalidationVersionMap& initial_max_invalidation_versions, 77 const InvalidationStateMap& initial_invalidation_state_map,
76 const std::string& invalidation_bootstrap_data, 78 const std::string& invalidation_bootstrap_data,
77 const WeakHandle<InvalidationStateTracker>& invalidation_state_tracker, 79 const WeakHandle<InvalidationStateTracker>& invalidation_state_tracker,
78 const std::string& client_info) { 80 const std::string& client_info) {
79 DCHECK(notifier_options.request_context_getter); 81 DCHECK(notifier_options.request_context_getter);
80 DCHECK_EQ(notifier::NOTIFICATION_SERVER, 82 DCHECK_EQ(notifier::NOTIFICATION_SERVER,
81 notifier_options.notification_method); 83 notifier_options.notification_method);
82 network_task_runner_ = notifier_options.request_context_getter-> 84 network_task_runner_ = notifier_options.request_context_getter->
83 GetNetworkTaskRunner(); 85 GetNetworkTaskRunner();
84 DCHECK(network_task_runner_->BelongsToCurrentThread()); 86 DCHECK(network_task_runner_->BelongsToCurrentThread());
85 invalidation_notifier_.reset( 87 invalidation_notifier_.reset(
86 new InvalidationNotifier( 88 new InvalidationNotifier(
87 notifier::PushClient::CreateDefaultOnIOThread(notifier_options), 89 notifier::PushClient::CreateDefaultOnIOThread(notifier_options),
88 initial_max_invalidation_versions, 90 initial_invalidation_state_map,
89 invalidation_bootstrap_data, 91 invalidation_bootstrap_data,
90 invalidation_state_tracker, 92 invalidation_state_tracker,
91 client_info)); 93 client_info));
92 invalidation_notifier_->RegisterHandler(this); 94 invalidation_notifier_->RegisterHandler(this);
93 } 95 }
94 96
95 void NonBlockingInvalidator::Core::Teardown() { 97 void NonBlockingInvalidator::Core::Teardown() {
96 DCHECK(network_task_runner_->BelongsToCurrentThread()); 98 DCHECK(network_task_runner_->BelongsToCurrentThread());
97 invalidation_notifier_->UnregisterHandler(this); 99 invalidation_notifier_->UnregisterHandler(this);
98 invalidation_notifier_.reset(); 100 invalidation_notifier_.reset();
99 network_task_runner_ = NULL; 101 network_task_runner_ = NULL;
100 } 102 }
101 103
102 void NonBlockingInvalidator::Core::UpdateRegisteredIds(const ObjectIdSet& ids) { 104 void NonBlockingInvalidator::Core::UpdateRegisteredIds(const ObjectIdSet& ids) {
103 DCHECK(network_task_runner_->BelongsToCurrentThread()); 105 DCHECK(network_task_runner_->BelongsToCurrentThread());
104 invalidation_notifier_->UpdateRegisteredIds(this, ids); 106 invalidation_notifier_->UpdateRegisteredIds(this, ids);
105 } 107 }
106 108
109 void NonBlockingInvalidator::Core::Acknowledge(const invalidation::ObjectId& id,
110 const AckHandle& ack_handle) {
111 DCHECK(network_task_runner_->BelongsToCurrentThread());
112 invalidation_notifier_->Acknowledge(id, ack_handle);
113 }
114
107 void NonBlockingInvalidator::Core::SetUniqueId(const std::string& unique_id) { 115 void NonBlockingInvalidator::Core::SetUniqueId(const std::string& unique_id) {
108 DCHECK(network_task_runner_->BelongsToCurrentThread()); 116 DCHECK(network_task_runner_->BelongsToCurrentThread());
109 invalidation_notifier_->SetUniqueId(unique_id); 117 invalidation_notifier_->SetUniqueId(unique_id);
110 } 118 }
111 119
112 void NonBlockingInvalidator::Core::SetStateDeprecated( 120 void NonBlockingInvalidator::Core::SetStateDeprecated(
113 const std::string& state) { 121 const std::string& state) {
114 DCHECK(network_task_runner_->BelongsToCurrentThread()); 122 DCHECK(network_task_runner_->BelongsToCurrentThread());
115 invalidation_notifier_->SetStateDeprecated(state); 123 invalidation_notifier_->SetStateDeprecated(state);
116 } 124 }
(...skipping 16 matching lines...) Expand all
133 IncomingInvalidationSource source) { 141 IncomingInvalidationSource source) {
134 DCHECK(network_task_runner_->BelongsToCurrentThread()); 142 DCHECK(network_task_runner_->BelongsToCurrentThread());
135 delegate_observer_.Call(FROM_HERE, 143 delegate_observer_.Call(FROM_HERE,
136 &InvalidationHandler::OnIncomingInvalidation, 144 &InvalidationHandler::OnIncomingInvalidation,
137 invalidation_map, 145 invalidation_map,
138 source); 146 source);
139 } 147 }
140 148
141 NonBlockingInvalidator::NonBlockingInvalidator( 149 NonBlockingInvalidator::NonBlockingInvalidator(
142 const notifier::NotifierOptions& notifier_options, 150 const notifier::NotifierOptions& notifier_options,
143 const InvalidationVersionMap& initial_max_invalidation_versions, 151 const InvalidationStateMap& initial_invalidation_state_map,
144 const std::string& invalidation_bootstrap_data, 152 const std::string& invalidation_bootstrap_data,
145 const WeakHandle<InvalidationStateTracker>& 153 const WeakHandle<InvalidationStateTracker>&
146 invalidation_state_tracker, 154 invalidation_state_tracker,
147 const std::string& client_info) 155 const std::string& client_info)
148 : weak_ptr_factory_(ALLOW_THIS_IN_INITIALIZER_LIST(this)), 156 : weak_ptr_factory_(ALLOW_THIS_IN_INITIALIZER_LIST(this)),
149 core_( 157 core_(
150 new Core(MakeWeakHandle(weak_ptr_factory_.GetWeakPtr()))), 158 new Core(MakeWeakHandle(weak_ptr_factory_.GetWeakPtr()))),
151 parent_task_runner_( 159 parent_task_runner_(
152 base::ThreadTaskRunnerHandle::Get()), 160 base::ThreadTaskRunnerHandle::Get()),
153 network_task_runner_(notifier_options.request_context_getter-> 161 network_task_runner_(notifier_options.request_context_getter->
154 GetNetworkTaskRunner()) { 162 GetNetworkTaskRunner()) {
155 if (!network_task_runner_->PostTask( 163 if (!network_task_runner_->PostTask(
156 FROM_HERE, 164 FROM_HERE,
157 base::Bind( 165 base::Bind(
158 &NonBlockingInvalidator::Core::Initialize, 166 &NonBlockingInvalidator::Core::Initialize,
159 core_.get(), 167 core_.get(),
160 notifier_options, 168 notifier_options,
161 initial_max_invalidation_versions, 169 initial_invalidation_state_map,
162 invalidation_bootstrap_data, 170 invalidation_bootstrap_data,
163 invalidation_state_tracker, 171 invalidation_state_tracker,
164 client_info))) { 172 client_info))) {
165 NOTREACHED(); 173 NOTREACHED();
166 } 174 }
167 } 175 }
168 176
169 NonBlockingInvalidator::~NonBlockingInvalidator() { 177 NonBlockingInvalidator::~NonBlockingInvalidator() {
170 DCHECK(parent_task_runner_->BelongsToCurrentThread()); 178 DCHECK(parent_task_runner_->BelongsToCurrentThread());
171 if (!network_task_runner_->PostTask( 179 if (!network_task_runner_->PostTask(
(...skipping 21 matching lines...) Expand all
193 registrar_.GetAllRegisteredIds()))) { 201 registrar_.GetAllRegisteredIds()))) {
194 NOTREACHED(); 202 NOTREACHED();
195 } 203 }
196 } 204 }
197 205
198 void NonBlockingInvalidator::UnregisterHandler(InvalidationHandler* handler) { 206 void NonBlockingInvalidator::UnregisterHandler(InvalidationHandler* handler) {
199 DCHECK(parent_task_runner_->BelongsToCurrentThread()); 207 DCHECK(parent_task_runner_->BelongsToCurrentThread());
200 registrar_.UnregisterHandler(handler); 208 registrar_.UnregisterHandler(handler);
201 } 209 }
202 210
211 void NonBlockingInvalidator::Acknowledge(const invalidation::ObjectId& id,
212 const AckHandle& ack_handle) {
213 DCHECK(parent_task_runner_->BelongsToCurrentThread());
214 if (!network_task_runner_->PostTask(
215 FROM_HERE,
216 base::Bind(
217 &NonBlockingInvalidator::Core::Acknowledge,
218 core_.get(),
219 id,
220 ack_handle))) {
221 NOTREACHED();
222 }
223 }
224
203 InvalidatorState NonBlockingInvalidator::GetInvalidatorState() const { 225 InvalidatorState NonBlockingInvalidator::GetInvalidatorState() const {
204 DCHECK(parent_task_runner_->BelongsToCurrentThread()); 226 DCHECK(parent_task_runner_->BelongsToCurrentThread());
205 return registrar_.GetInvalidatorState(); 227 return registrar_.GetInvalidatorState();
206 } 228 }
207 229
208 void NonBlockingInvalidator::SetUniqueId(const std::string& unique_id) { 230 void NonBlockingInvalidator::SetUniqueId(const std::string& unique_id) {
209 DCHECK(parent_task_runner_->BelongsToCurrentThread()); 231 DCHECK(parent_task_runner_->BelongsToCurrentThread());
210 if (!network_task_runner_->PostTask( 232 if (!network_task_runner_->PostTask(
211 FROM_HERE, 233 FROM_HERE,
212 base::Bind(&NonBlockingInvalidator::Core::SetUniqueId, 234 base::Bind(&NonBlockingInvalidator::Core::SetUniqueId,
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 } 272 }
251 273
252 void NonBlockingInvalidator::OnIncomingInvalidation( 274 void NonBlockingInvalidator::OnIncomingInvalidation(
253 const ObjectIdInvalidationMap& invalidation_map, 275 const ObjectIdInvalidationMap& invalidation_map,
254 IncomingInvalidationSource source) { 276 IncomingInvalidationSource source) {
255 DCHECK(parent_task_runner_->BelongsToCurrentThread()); 277 DCHECK(parent_task_runner_->BelongsToCurrentThread());
256 registrar_.DispatchInvalidationsToHandlers(invalidation_map, source); 278 registrar_.DispatchInvalidationsToHandlers(invalidation_map, source);
257 } 279 }
258 280
259 } // namespace syncer 281 } // namespace syncer
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698