NOT FOR COMMIT: Add DeviceInfo type and ChangeProcessor

sync/protocol/proto_value_conversions.h

Index: sync/protocol/proto_value_conversions.h
diff --git a/sync/protocol/proto_value_conversions.h b/sync/protocol/proto_value_conversions.h
index a1e938bb2a4ae3d7a8d05d6f527504d88a58ce41..597b7677783914ffdb9f69a39d43e7fe9bf87e33 100644
--- a/sync/protocol/proto_value_conversions.h
+++ b/sync/protocol/proto_value_conversions.h
@@ -21,6 +21,7 @@ class AutofillSpecifics;
 class BookmarkSpecifics;
 class ClientToServerMessage;
 class ClientToServerResponse;
+class DeviceInfoSpecifics;

[Nicolas Zea, 2012/09/14 19:15:08]

down one line

[rlarocque, 2012/09/15 01:36:37]

Not according to ASCII sort.

[Nicolas Zea, 2012/09/17 17:54:00]

*Specifics vs *rmation? I would have thought r sorts before S, is it treating
capitals differently? 

[rlarocque, 2012/09/19 21:37:58]

'S' is 0x53, r is '0x72'.  'S' < 'r'.

The sort behaviour of most programs is dependent on LC_COLLATE.  I try to sort
with LC_COLLATE=C, which is why I get this unintuitive ordering.

 class DeviceInformation;
 class EncryptedData;
 class EntitySpecifics;
@@ -81,11 +82,6 @@ base::DictionaryValue* TabNavigationToValue(
 base::DictionaryValue* PasswordSpecificsDataToValue(
     const sync_pb::PasswordSpecificsData& password_specifics_data);
 
-// Sub-protocol of NigoriSpecifics.
-
-base::DictionaryValue* DeviceInformationToValue(
-    const sync_pb::DeviceInformation& device_information);
-
 // Main *SpecificsToValue functions.
 
 base::DictionaryValue* AppNotificationToValue(
@@ -118,6 +114,9 @@ base::DictionaryValue* NigoriSpecificsToValue(
 base::DictionaryValue* PasswordSpecificsToValue(
     const sync_pb::PasswordSpecifics& password_specifics);
 
+base::DictionaryValue* DeviceInfoSpecificsToValue(
+    const sync_pb::DeviceInfoSpecifics& device_info_specifics);
+
 base::DictionaryValue* PreferenceSpecificsToValue(
     const sync_pb::PreferenceSpecifics& password_specifics);