NOT FOR COMMIT: Add DeviceInfo type and ChangeProcessor

sync/test/mock_transaction_observer.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SYNC_TEST_MOCK_TRANSACTION_OBSERVER_H_
+#define SYNC_TEST_MOCK_TRANSACTION_OBSERVER_H_
+
+#include "base/memory/weak_ptr.h"
+#include "sync/internal_api/public/base/model_type.h"
+#include "sync/syncable/transaction_observer.h"
+#include "sync/syncable/write_transaction_info.h"
+
+namespace syncer {
+namespace syncable {
+
+// This class acts as a TransactionObserver for the syncable::Directory.
+// It gathers information that is useful for writing test assertions.

[Nicolas Zea, 2012/09/14 19:15:08]

mention that it only counts transactions with syncable changes? I wonder if the
name of the class should reflect that too, otherwise you might think it counts
all transactions.

[rlarocque, 2012/09/15 01:36:37]

I added a comment to the transactions_observed() method.

+class MockTransactionObserver :
+  public base::SupportsWeakPtr<MockTransactionObserver>,
+  public TransactionObserver {
+ public:
+  MockTransactionObserver();
+  virtual ~MockTransactionObserver();
+  virtual void OnTransactionWrite(
+      const ImmutableWriteTransactionInfo& write_transaction_info,
+      ModelTypeSet models_with_changes) OVERRIDE;
+
+  int transactions_observed();
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(MockTransactionObserver);
+
+  int transactions_observed_;
+};
+
+}  // namespace syncable
+}  // namespace syncer
+
+
+#endif  // SYNC_TEST_MOCK_TRANSACTION_OBSERVER_H_