Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/browser/sync/glue/session_model_associator.cc

Issue 10911073: NOT FOR COMMIT: Add DeviceInfo type and ChangeProcessor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes from review comments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/glue/session_model_associator.h" 5 #include "chrome/browser/sync/glue/session_model_associator.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <set> 8 #include <set>
9 #include <utility> 9 #include <utility>
10 10
11 #include "base/bind.h" 11 #include "base/bind.h"
12 #include "base/command_line.h" 12 #include "base/command_line.h"
13 #include "base/location.h" 13 #include "base/location.h"
14 #include "base/logging.h" 14 #include "base/logging.h"
15 #include "base/threading/sequenced_worker_pool.h" 15 #include "base/threading/sequenced_worker_pool.h"
16 #include "chrome/browser/favicon/favicon_service_factory.h" 16 #include "chrome/browser/favicon/favicon_service_factory.h"
17 #include "chrome/browser/history/history.h" 17 #include "chrome/browser/history/history.h"
18 #include "chrome/browser/prefs/pref_service.h" 18 #include "chrome/browser/prefs/pref_service.h"
19 #include "chrome/browser/profiles/profile.h" 19 #include "chrome/browser/profiles/profile.h"
20 #include "chrome/browser/sessions/session_id.h" 20 #include "chrome/browser/sessions/session_id.h"
21 #include "chrome/browser/sync/glue/synced_device_tracker.h"
21 #include "chrome/browser/sync/glue/synced_session.h" 22 #include "chrome/browser/sync/glue/synced_session.h"
22 #include "chrome/browser/sync/glue/synced_tab_delegate.h" 23 #include "chrome/browser/sync/glue/synced_tab_delegate.h"
23 #include "chrome/browser/sync/glue/synced_window_delegate.h" 24 #include "chrome/browser/sync/glue/synced_window_delegate.h"
24 #include "chrome/browser/sync/profile_sync_service.h" 25 #include "chrome/browser/sync/profile_sync_service.h"
25 #include "chrome/common/chrome_notification_types.h" 26 #include "chrome/common/chrome_notification_types.h"
26 #include "chrome/common/chrome_switches.h" 27 #include "chrome/common/chrome_switches.h"
27 #include "chrome/common/pref_names.h" 28 #include "chrome/common/pref_names.h"
28 #include "chrome/common/url_constants.h" 29 #include "chrome/common/url_constants.h"
29 #include "content/public/browser/navigation_entry.h" 30 #include "content/public/browser/navigation_entry.h"
30 #include "content/public/browser/notification_details.h" 31 #include "content/public/browser/notification_details.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 // Default number of days without activity after which a session is considered 70 // Default number of days without activity after which a session is considered
70 // stale and becomes a candidate for garbage collection. 71 // stale and becomes a candidate for garbage collection.
71 static const size_t kDefaultStaleSessionThresholdDays = 14; // 2 weeks. 72 static const size_t kDefaultStaleSessionThresholdDays = 14; // 2 weeks.
72 73
73 #if defined(OS_ANDROID) 74 #if defined(OS_ANDROID)
74 bool IsTabletUI() { 75 bool IsTabletUI() {
75 return CommandLine::ForCurrentProcess()->HasSwitch(switches::kTabletUI); 76 return CommandLine::ForCurrentProcess()->HasSwitch(switches::kTabletUI);
76 } 77 }
77 #endif 78 #endif
78 79
79 sync_pb::SessionHeader::DeviceType GetLocalDeviceType() {
80 // TODO(yfriedman): Refactor/combine with "DeviceInformation" code in
81 // sync_manager.cc[1060]
82 #if defined(OS_CHROMEOS)
83 return sync_pb::SessionHeader_DeviceType_TYPE_CROS;
84 #elif defined(OS_LINUX)
85 return sync_pb::SessionHeader_DeviceType_TYPE_LINUX;
86 #elif defined(OS_MACOSX)
87 return sync_pb::SessionHeader_DeviceType_TYPE_MAC;
88 #elif defined(OS_WIN)
89 return sync_pb::SessionHeader_DeviceType_TYPE_WIN;
90 #elif defined(OS_ANDROID)
91 return IsTabletUI() ?
92 sync_pb::SessionHeader_DeviceType_TYPE_TABLET :
93 sync_pb::SessionHeader_DeviceType_TYPE_PHONE;
94 #else
95 return sync_pb::SessionHeader_DeviceType_TYPE_OTHER;
96 #endif
97 }
98
99 } // namespace 80 } // namespace
100 81
101 SessionModelAssociator::SessionModelAssociator(ProfileSyncService* sync_service, 82 SessionModelAssociator::SessionModelAssociator(ProfileSyncService* sync_service,
102 DataTypeErrorHandler* error_handler) 83 DataTypeErrorHandler* error_handler)
103 : tab_pool_(sync_service), 84 : tab_pool_(sync_service),
104 local_session_syncid_(syncer::kInvalidId), 85 local_session_syncid_(syncer::kInvalidId),
105 sync_service_(sync_service), 86 sync_service_(sync_service),
106 stale_session_threshold_days_(kDefaultStaleSessionThresholdDays), 87 stale_session_threshold_days_(kDefaultStaleSessionThresholdDays),
107 setup_for_test_(false), 88 setup_for_test_(false),
108 waiting_for_change_(false), 89 waiting_for_change_(false),
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 syncer::SyncError* error) { 177 syncer::SyncError* error) {
197 DCHECK(CalledOnValidThread()); 178 DCHECK(CalledOnValidThread());
198 std::string local_tag = GetCurrentMachineTag(); 179 std::string local_tag = GetCurrentMachineTag();
199 sync_pb::SessionSpecifics specifics; 180 sync_pb::SessionSpecifics specifics;
200 specifics.set_session_tag(local_tag); 181 specifics.set_session_tag(local_tag);
201 sync_pb::SessionHeader* header_s = specifics.mutable_header(); 182 sync_pb::SessionHeader* header_s = specifics.mutable_header();
202 SyncedSession* current_session = 183 SyncedSession* current_session =
203 synced_session_tracker_.GetSession(local_tag); 184 synced_session_tracker_.GetSession(local_tag);
204 current_session->modified_time = base::Time::Now(); 185 current_session->modified_time = base::Time::Now();
205 header_s->set_client_name(current_session_name_); 186 header_s->set_client_name(current_session_name_);
206 header_s->set_device_type(GetLocalDeviceType()); 187 header_s->set_device_type(SyncedDeviceTracker::GetLocalDeviceType());
207 188
208 synced_session_tracker_.ResetSessionTracking(local_tag); 189 synced_session_tracker_.ResetSessionTracking(local_tag);
209 std::set<SyncedWindowDelegate*> windows = 190 std::set<SyncedWindowDelegate*> windows =
210 SyncedWindowDelegate::GetSyncedWindowDelegates(); 191 SyncedWindowDelegate::GetSyncedWindowDelegates();
211 for (std::set<SyncedWindowDelegate*>::const_iterator i = 192 for (std::set<SyncedWindowDelegate*>::const_iterator i =
212 windows.begin(); i != windows.end(); ++i) { 193 windows.begin(); i != windows.end(); ++i) {
213 // Make sure the window has tabs and a viewable window. The viewable window 194 // Make sure the window has tabs and a viewable window. The viewable window
214 // check is necessary because, for example, when a browser is closed the 195 // check is necessary because, for example, when a browser is closed the
215 // destructor is not necessarily run immediately. This means its possible 196 // destructor is not necessarily run immediately. This means its possible
216 // for us to get a handle to a browser that is about to be removed. If 197 // for us to get a handle to a browser that is about to be removed. If
(...skipping 573 matching lines...) Expand 10 before | Expand all | Expand 10 after
790 model_type()); 771 model_type());
791 } 772 }
792 773
793 // Write the initial values to the specifics so that in case of a crash or 774 // Write the initial values to the specifics so that in case of a crash or
794 // error we don't persist a half-written node. 775 // error we don't persist a half-written node.
795 write_node.SetTitle(UTF8ToWide(current_machine_tag_)); 776 write_node.SetTitle(UTF8ToWide(current_machine_tag_));
796 sync_pb::SessionSpecifics base_specifics; 777 sync_pb::SessionSpecifics base_specifics;
797 base_specifics.set_session_tag(current_machine_tag_); 778 base_specifics.set_session_tag(current_machine_tag_);
798 sync_pb::SessionHeader* header_s = base_specifics.mutable_header(); 779 sync_pb::SessionHeader* header_s = base_specifics.mutable_header();
799 header_s->set_client_name(current_session_name_); 780 header_s->set_client_name(current_session_name_);
800 header_s->set_device_type(GetLocalDeviceType()); 781 header_s->set_device_type(SyncedDeviceTracker::GetLocalDeviceType());
801 write_node.SetSessionSpecifics(base_specifics); 782 write_node.SetSessionSpecifics(base_specifics);
802 783
803 local_session_syncid_ = write_node.GetId(); 784 local_session_syncid_ = write_node.GetId();
804 } 785 }
805 } 786 }
806 787
807 // Check if anything has changed on the client side. 788 // Check if anything has changed on the client side.
808 if (!UpdateSyncModelDataFromClient(&error)) { 789 if (!UpdateSyncModelDataFromClient(&error)) {
809 DCHECK(error.IsSet()); 790 DCHECK(error.IsSet());
810 return error; 791 return error;
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
1116 // Static 1097 // Static
1117 void SessionModelAssociator::PopulateSessionHeaderFromSpecifics( 1098 void SessionModelAssociator::PopulateSessionHeaderFromSpecifics(
1118 const sync_pb::SessionHeader& header_specifics, 1099 const sync_pb::SessionHeader& header_specifics,
1119 const base::Time& mtime, 1100 const base::Time& mtime,
1120 SyncedSession* session_header) { 1101 SyncedSession* session_header) {
1121 if (header_specifics.has_client_name()) { 1102 if (header_specifics.has_client_name()) {
1122 session_header->session_name = header_specifics.client_name(); 1103 session_header->session_name = header_specifics.client_name();
1123 } 1104 }
1124 if (header_specifics.has_device_type()) { 1105 if (header_specifics.has_device_type()) {
1125 switch (header_specifics.device_type()) { 1106 switch (header_specifics.device_type()) {
1126 case sync_pb::SessionHeader_DeviceType_TYPE_WIN: 1107 case sync_pb::SyncEnums_DeviceType_TYPE_WIN:
1127 session_header->device_type = SyncedSession::TYPE_WIN; 1108 session_header->device_type = SyncedSession::TYPE_WIN;
1128 break; 1109 break;
1129 case sync_pb::SessionHeader_DeviceType_TYPE_MAC: 1110 case sync_pb::SyncEnums_DeviceType_TYPE_MAC:
1130 session_header->device_type = SyncedSession::TYPE_MACOSX; 1111 session_header->device_type = SyncedSession::TYPE_MACOSX;
1131 break; 1112 break;
1132 case sync_pb::SessionHeader_DeviceType_TYPE_LINUX: 1113 case sync_pb::SyncEnums_DeviceType_TYPE_LINUX:
1133 session_header->device_type = SyncedSession::TYPE_LINUX; 1114 session_header->device_type = SyncedSession::TYPE_LINUX;
1134 break; 1115 break;
1135 case sync_pb::SessionHeader_DeviceType_TYPE_CROS: 1116 case sync_pb::SyncEnums_DeviceType_TYPE_CROS:
1136 session_header->device_type = SyncedSession::TYPE_CHROMEOS; 1117 session_header->device_type = SyncedSession::TYPE_CHROMEOS;
1137 break; 1118 break;
1138 case sync_pb::SessionHeader_DeviceType_TYPE_PHONE: 1119 case sync_pb::SyncEnums_DeviceType_TYPE_PHONE:
1139 session_header->device_type = SyncedSession::TYPE_PHONE; 1120 session_header->device_type = SyncedSession::TYPE_PHONE;
1140 break; 1121 break;
1141 case sync_pb::SessionHeader_DeviceType_TYPE_TABLET: 1122 case sync_pb::SyncEnums_DeviceType_TYPE_TABLET:
1142 session_header->device_type = SyncedSession::TYPE_TABLET; 1123 session_header->device_type = SyncedSession::TYPE_TABLET;
1143 break; 1124 break;
1144 case sync_pb::SessionHeader_DeviceType_TYPE_OTHER: 1125 case sync_pb::SyncEnums_DeviceType_TYPE_OTHER:
1145 // Intentionally fall-through 1126 // Intentionally fall-through
1146 default: 1127 default:
1147 session_header->device_type = SyncedSession::TYPE_OTHER; 1128 session_header->device_type = SyncedSession::TYPE_OTHER;
1148 break; 1129 break;
1149 } 1130 }
1150 } 1131 }
1151 session_header->modified_time = mtime; 1132 session_header->modified_time = mtime;
1152 } 1133 }
1153 1134
1154 // Static 1135 // Static
(...skipping 442 matching lines...) Expand 10 before | Expand all | Expand 10 after
1597 1578
1598 bool SessionModelAssociator::CryptoReadyIfNecessary() { 1579 bool SessionModelAssociator::CryptoReadyIfNecessary() {
1599 // We only access the cryptographer while holding a transaction. 1580 // We only access the cryptographer while holding a transaction.
1600 syncer::ReadTransaction trans(FROM_HERE, sync_service_->GetUserShare()); 1581 syncer::ReadTransaction trans(FROM_HERE, sync_service_->GetUserShare());
1601 const syncer::ModelTypeSet encrypted_types = trans.GetEncryptedTypes(); 1582 const syncer::ModelTypeSet encrypted_types = trans.GetEncryptedTypes();
1602 return !encrypted_types.Has(SESSIONS) || 1583 return !encrypted_types.Has(SESSIONS) ||
1603 sync_service_->IsCryptographerReady(&trans); 1584 sync_service_->IsCryptographerReady(&trans);
1604 } 1585 }
1605 1586
1606 } // namespace browser_sync 1587 } // namespace browser_sync
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698