NOT FOR COMMIT: Add DeviceInfo type and ChangeProcessor

chrome/browser/sync/glue/DEPS

 include_rules = [
   "-sync/engine",
   "-sync/sessions",
   "-sync/syncable",
 
   "+sync/internal_api/public",
   "+sync/util",
+  "+sync/test",

[Nicolas Zea, 2012/09/14 19:15:08]

Could the mock transaction observer (at least the header) be moved to
sync/internal_api/public/test? 

[rlarocque, 2012/09/15 01:36:37]

I agree that it should be moved somewhere.  I tentatively put it in sync/test
because the other test transaction observer, NullTransactionObserver, lives
there.  

I don't think that sync/internal_api/public_test is the right place to put it,
though.  The TransactionObserver interface is in syncable, not internal_api. 
I'm also worried about the implications the move would have on linking/symbols.

[Nicolas Zea, 2012/09/17 17:54:00]

One solution is to just have the header file not expose the observer
implementation, and instead have the only transactions_observed() method. You'd
then have a a transaction observer object (which you forward declare in the
header), whose implementation is in the cc file. Similar to SBH::Core.

I think in that scenario it would also be appropriate to rename the main class
to SyncNudgeObserver or something, since the fact that you're using a
transaction observer is an implementation detail.

 
   "+jingle/notifier/base",
 
   # Should these live in their own "includes" (e.g) directory(ies)?
   # Bug 19878.
   "+sync/notifier/invalidation_util.h",
   "+sync/notifier/mock_sync_notifier_observer.h",
   "+sync/notifier/sync_notifier.h",
   "+sync/notifier/sync_notifier_helper.h",
   "+sync/notifier/sync_notifier_factory.h",
   "+sync/notifier/sync_notifier_observer.h",
 
   # TODO(zea): SessionModelAssociator shouldn't need this.

[Nicolas Zea, 2012/09/14 19:15:08]

I guess we can remove this TODO now? or perhaps change it to reflect that we
need to expose the cache guid at the glue layer

[rlarocque, 2012/09/15 01:36:37]

Unfortunately, it's still necessary for several reasons, not just the cache
guid:

ERROR in
/usr/local/google/storage/chromium2/src/chrome/browser/sync/glue/session_model_associator.cc
  Illegal include: "sync/syncable/directory.h"
    Because of "-sync/syncable" from chrome/browser/sync/glue's include_rules.
  Illegal include: "sync/syncable/write_transaction.h"
    Because of "-sync/syncable" from chrome/browser/sync/glue's include_rules.

ERROR in
/usr/local/google/storage/chromium2/src/chrome/browser/sync/glue/typed_url_change_processor.cc
  Illegal include: "sync/syncable/entry.h"
    Because of "-sync/syncable" from chrome/browser/sync/glue's include_rules.

ERROR in
/usr/local/google/storage/chromium2/src/chrome/browser/sync/glue/synced_device_tracker.cc
  Illegal include: "sync/syncable/directory.h"
    Because of "-sync/syncable" from chrome/browser/sync/glue's include_rules.

ERROR in
/usr/local/google/storage/chromium2/src/chrome/browser/sync/glue/generic_change_processor.cc
  Illegal include: "sync/syncable/entry.h"
    Because of "-sync/syncable" from chrome/browser/sync/glue's include_rules.

ERROR in
/usr/local/google/storage/chromium2/src/chrome/browser/sync/glue/bookmark_change_processor.cc
  Illegal include: "sync/syncable/entry.h"
    Because of "-sync/syncable" from chrome/browser/sync/glue's include_rules.

I could update the comment, though.

[Nicolas Zea, 2012/09/17 17:54:00]

Right, I meant the comment itself is no longer quite appropriate, not that we
can remove the dependency itself.

   "+sync/syncable",
 
   # TODO(tim): This shouldn't be needed.
   "+sync/util/cryptographer.h"
 
 ]