Fixed parsing of parameterized type test assert statement in production mode.

runtime/vm/parser.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/compiler_stats.h"
@@ skipping 9325 matching lines @@
 }
 
 
 void Parser::SkipBinaryExpr() {
   SkipUnaryExpr();
   const int min_prec = Token::Precedence(Token::kOR);
   const int max_prec = Token::Precedence(Token::kMUL);
   while (((min_prec <= Token::Precedence(CurrentToken())) &&
       (Token::Precedence(CurrentToken()) <= max_prec)) ||
       IsLiteral("as")) {
-    ConsumeToken();
-    SkipUnaryExpr();
+    if (CurrentToken() == Token::kIS) {

[hausner, 2012/08/31 23:31:35]

I think there is another bug here. After the keyword 'as' we also need to skip a
type, not a unary expression. E.g:

assert((e as List<int>).length == 10);

If we don't have any tests for this, it would be good to add one and run it with
assertions enabled and disabled, so we both parse the expression (if assertions
are enabled) and skip the expression (if assertions are disabled).

+      ConsumeToken();
+      if (CurrentToken() == Token::kNOT) {
+        ConsumeToken();
+      }
+      SkipType(false);
+    } else {
+      ConsumeToken();
+      SkipUnaryExpr();
+    }
   }
 }
 
 
 void Parser::SkipConditionalExpr() {
   SkipBinaryExpr();
   if (CurrentToken() == Token::kCONDITIONAL) {
     ConsumeToken();
     SkipExpr();
     ExpectToken(Token::kCOLON);
@@ skipping 24 matching lines @@
 void Parser::SkipQualIdent() {
   ASSERT(IsIdentifier());
   ConsumeToken();
   if (CurrentToken() == Token::kPERIOD) {
     ConsumeToken();  // Consume the kPERIOD token.
     ExpectIdentifier("identifier expected after '.'");
   }
 }
 
 }  // namespace dart