Enable commands API for platform apps.

chrome/browser/ui/gtk/extensions/shell_window_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/extensions/shell_window_gtk.h"
 
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.h"
 #include "chrome/browser/ui/gtk/gtk_window_util.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/extensions/draggable_region.h"
 #include "chrome/common/extensions/extension.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
 #include "ui/base/x/active_window_watcher_x.h"
 #include "ui/gfx/rect.h"
@@ skipping 67 matching lines @@
                    G_CALLBACK(OnMainWindowDeleteEventThunk), this);
   g_signal_connect(window_, "configure-event",
                    G_CALLBACK(OnConfigureThunk), this);
   g_signal_connect(window_, "window-state-event",
                    G_CALLBACK(OnWindowStateThunk), this);
   if (frameless_) {
     g_signal_connect(window_, "button-press-event",
                      G_CALLBACK(OnButtonPressThunk), this);
   }
 
+  // Add the keybinding registry, now that the window has been realized.

[Evan Stade, 2012/09/05 21:38:27]

are you sure the window has been realized? Note that realization is something
that occurs to GdkWindows, not GtkWindows.

If ExtensionKeybindingRegistryGtk requires the GdkWindow (i.e. window_->window)
to be realized before construction, you should probably document that somewhere.

[Marijn Kruisselbrink, 2012/09/06 18:09:57]

Ah yes, I'm not sure actually if ExtensionKeybindingRegistryGtk requires the
window to be realized. I just copied this bit from browser_window_gtk, and there
the code just before it calls gtk_widget_realize. It seems to work fine, but to
be honest I don't really know what gtk_widget_realize does that could influence
this. I don't think ExtensionKeybindingRegistryGtk does anything that requires
the widget to be realized, so maybe I can just remove the part of the comment
that talks about the window being realized?

+  extension_keybinding_registry_.reset(
+      new ExtensionKeybindingRegistryGtk(shell_window_->profile(), window_,
+          extensions::ExtensionKeybindingRegistry::PLATFORM_APPS_ONLY));
+
   ui::ActiveWindowWatcherX::AddObserver(this);
 }
 
 ShellWindowGtk::~ShellWindowGtk() {
   ui::ActiveWindowWatcherX::RemoveObserver(this);
 }
 
 bool ShellWindowGtk::IsActive() const {
   return is_active_;
 }
@@ skipping 204 matching lines @@
   }
 
   draggable_region_ = draggable_region;
 }
 
 // static
 NativeShellWindow* NativeShellWindow::Create(
     ShellWindow* shell_window, const ShellWindow::CreateParams& params) {
   return new ShellWindowGtk(shell_window, params);
 }