chrome_frame/urlmon_upload_data_stream.cc - Issue 10910268: net: Make UploadDataStream::Read() asynchronous

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/urlmon_upload_data_stream.cc

Issue 10910268: net: Make UploadDataStream::Read() asynchronous (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revised comments Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome_frame/urlmon_upload_data_stream.cc

diff --git a/chrome_frame/urlmon_upload_data_stream.cc b/chrome_frame/urlmon_upload_data_stream.cc

index 8aae0df7ed6bf66618d321903490c2f384ab56b9..05a2b14314a70572f986719feceffde27fdfa11e 100644

--- a/chrome_frame/urlmon_upload_data_stream.cc

+++ b/chrome_frame/urlmon_upload_data_stream.cc

@@ -41,7 +41,7 @@ STDMETHODIMP UrlmonUploadDataStream::Read(void* pv, ULONG cb, ULONG* read) {

scoped_refptr<net::IOBufferWithSize> buf(

new net::IOBufferWithSize(bytes_to_copy_now));

- int bytes_read = request_body_stream_->Read(buf, buf->size());

+ int bytes_read = request_body_stream_->ReadSync(buf, buf->size());

if (bytes_read == 0) // Reached the end of the stream.

break;

« no previous file with comments | « no previous file | net/base/upload_bytes_element_reader.h » ('j') | net/base/upload_data_stream.h » ('J')