net/spdy/spdy_http_stream.cc - Issue 10910268: net: Make UploadDataStream::Read() asynchronous

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_http_stream.cc

Issue 10910268: net: Make UploadDataStream::Read() asynchronous (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: _ Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_http_stream.cc

diff --git a/net/spdy/spdy_http_stream.cc b/net/spdy/spdy_http_stream.cc

index f642dc4b326e901a26bbbe2e54758f07277dbcbb..0448f787b6cd96cf306b7ea9814fc665e30580a6 100644

--- a/net/spdy/spdy_http_stream.cc

+++ b/net/spdy/spdy_http_stream.cc

@@ -283,7 +283,7 @@ int SpdyHttpStream::SendData() {

CHECK_EQ(0, request_body_buf_->BytesRemaining());

// Read the data from the request body stream.

- const int bytes_read = request_body_stream_->Read(

+ const int bytes_read = request_body_stream_->ReadSync(

willchan no longer on Chromium 2012/09/24 23:37:08 It'd be great if we could switch to Read() instead

hashimoto 2012/09/25 10:47:56 I will do it soon :)

raw_request_body_buf_, raw_request_body_buf_->size());

DCHECK(!waiting_for_chunk_ || bytes_read != ERR_IO_PENDING);