SearchViewController needs more tests

chrome/browser/ui/views/frame/contents_container.h

Index: chrome/browser/ui/views/frame/contents_container.h
diff --git a/chrome/browser/ui/views/frame/contents_container.h b/chrome/browser/ui/views/frame/contents_container.h
index 3227688ad56d91f6b0f1df7737597a026d066252..a342b7110f3d26daf5f59b006588ca98d7d441a2 100644
--- a/chrome/browser/ui/views/frame/contents_container.h
+++ b/chrome/browser/ui/views/frame/contents_container.h
@@ -30,11 +30,11 @@ class ContentsContainer : public views::View {
   // when the |SearchViewController| is displaying the NTP, and activated
   // otherwise.  Deactivation removes the active view from the view hierarchy.
   void SetActive(views::WebView* active);
-  views::WebView* active() { return active_; }
+  views::WebView* active() const { return active_; }

[sky, 2012/09/12 21:28:49]

const methods shouldn't return non-const objects, else they be used to
circumvent the constness of this.

[dhollowa, 2012/09/12 22:12:01]

Done.

 
   // Sets the overlay. The overlay is sized to the bounds of this view.
   void SetOverlay(views::View* overlay);
-  views::View* overlay() { return overlay_; }
+  views::View* overlay() const { return overlay_; }
 
   // Makes the preview view the active view and nulls out the old active view.
   // It's assumed the caller will delete or remove the old active view
@@ -44,7 +44,7 @@ class ContentsContainer : public views::View {
   // Sets the preview view. This does not delete the old.
   void SetPreview(views::WebView* preview,
                   content::WebContents* preview_web_contents);
-
+  views::WebView* preview() const { return preview_; }
   content::WebContents* preview_web_contents() const {
     return preview_web_contents_;
   }