Add new PathService paths for Windows' All Users Desktop and Quick Launch folders.

base/base_paths_default_posix.cc

Index: base/base_paths_default_posix.cc
diff --git a/base/base_paths_posix.cc b/base/base_paths_default_posix.cc
similarity index 91%
rename from base/base_paths_posix.cc
rename to base/base_paths_default_posix.cc
index 9be441d6d2616baa2458a3ed44b5ee1332db5963..8cf699591b35d3261e2b7693dd44b254f073b647 100644
--- a/base/base_paths_posix.cc
+++ b/base/base_paths_default_posix.cc
@@ -2,12 +2,15 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "base/base_paths.h"
+// Defines base::PathProviderPosix which is the default path provider for paths

[brettw, 2012/09/14 22:10:06]

Isn't this just used on Liunx then? I think base_paths_linux would be more
clear.

[gab, 2012/09/16 03:13:51]

I was saying the same thing, but grt@ didn't agree. Technically if you look at
the definition of OS_POSIX in build/build_config.h it's more than just linux
even when stripped from Mac and Android:
#if defined(OS_MACOSX) || defined(OS_LINUX) || defined(OS_FREEBSD) ||     \
    defined(OS_OPENBSD) || defined(OS_SOLARIS) || defined(OS_ANDROID) ||  \
    defined(OS_NACL)
#define OS_POSIX 1
#endif

However if you look at build\filename_rules.gypi:34
(http://code.google.com/searchframe#OAMlx_jo-ck/src/build/filename_rules.gypi&...):
_linux files are not excluded on *BSD OSes (although this is incorrect according
to TODO on line above so we should probably not worsen the situation; not to
mention that *BSD doesn't include SOLARIS...).

Overall, this file is really meant to be _posix imo, but it's overwritten by two
of the POSIX OSes we support, hence why I like the _default_posix.cc name to
make it obvious it's posix, but is overriden in some scenarios (maybe we could
even wrap the whole file in #if !defined(OS_ANROID) && !defined(OS_MACOSX) as
it's useless to compile it under those two OSes...

+// on POSIX OSes that don't have their own base_paths_OS.cc implementation (i.e.
+// all POSIX OSes, but Mac and Android).
 
 #include <ostream>
 #include <string>
 
 #include "build/build_config.h"
+#include "base/base_paths.h"
 #include "base/environment.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
@@ -99,6 +102,10 @@ bool PathProviderPosix(int key, FilePath* result) {
                   << "Try running from your chromium/src directory.";
       return false;
     }
+    case base::DIR_USER_DESKTOP: {
+      *result = base::nix::GetXDGUserDirectory("DESKTOP", "Desktop");
+      return true;
+    }
     case base::DIR_CACHE: {
       scoped_ptr<base::Environment> env(base::Environment::Create());
       FilePath cache_dir(base::nix::GetXDGDirectory(env.get(), "XDG_CACHE_HOME",