Add new PathService paths for Windows' All Users Desktop and Quick Launch folders.

base/base_paths.h

Index: base/base_paths.h
diff --git a/base/base_paths.h b/base/base_paths.h
index 39edd164c38fbeb45a3579ab189d15df54f34de7..ac4c6960df97013881dd16b883a45e52f1fcb4d4 100644
--- a/base/base_paths.h
+++ b/base/base_paths.h
@@ -34,17 +34,7 @@ enum BasePathKey {
   DIR_SOURCE_ROOT,  // Returns the root of the source tree.  This key is useful
                     // for tests that need to locate various resources.  It
                     // should not be used outside of test code.
-#if defined(OS_POSIX)

[grt (UTC plus 2), 2012/09/14 15:35:16]

these paths are valid for all POSIX-like systems, whereas base_paths_posix.cc is
only for non-OSX and non-android systems.  by moving these two into
base_paths_posix.h, there's now a discontinuity in that base_paths_posix.h is
used on many platforms but base_paths_posix.cc is used on fewer.  i think this
is confusing.

[gab, 2012/09/14 18:10:06]

I agree; following the current convention in path_provider.cc that
PathProviderPosix is the default provider for POSIX OSes, but can be overridden
(as it is for Mac and Android), I renamed base_paths_posix.cc to
base_paths_default_posix.cc to make it clear that this is the default path
provider, not the absolute one, for POSIX.

-  DIR_CACHE,    // Directory where to put cache data.  Note this is
-                // *not* where the browser cache lives, but the
-                // browser cache can be a subdirectory.
-                // This is $XDG_CACHE_HOME on Linux and
-                // ~/Library/Caches on Mac.
-  DIR_HOME,     // $HOME on POSIX-like systems.
-#endif
-#if defined(OS_ANDROID)
-  DIR_ANDROID_EXTERNAL_STORAGE,  // Android external storage directory.
-#endif
+  DIR_USER_DESKTOP,  // Directory that correspond to the current user's desktop.

[grt (UTC plus 2), 2012/09/14 15:35:16]

"The current user's desktop."  (the above would need to be "...corresponds..."
to be grammatically correct, but it's overly wordy so i'd go with something more
concise.)

[gab, 2012/09/14 18:10:06]

Done.

 
   PATH_END
 };