Add new PathService paths for Windows' All Users Desktop and Quick Launch folders.

base/base_paths_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "base/base_paths_mac.h"
+// Defines base::PathProviderMac which replaces base::PathProviderPosix for
+// OS_MAXOSX in base/path_service.cc.
 
 #include <dlfcn.h>
 #import <Foundation/Foundation.h>
 #include <mach-o/dyld.h>
 
+#include "base/base_paths.h"
 #include "base/compiler_specific.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/mac/foundation_util.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 
 namespace {
 
@@ skipping 29 matching lines @@
 namespace base {
 
 bool PathProviderMac(int key, FilePath* result) {
   switch (key) {
     case base::FILE_EXE:
       GetNSExecutablePath(result);
       return true;
     case base::FILE_MODULE:
       return GetModulePathForAddress(result,
           reinterpret_cast<const void*>(&base::PathProviderMac));
-    case base::DIR_CACHE:
-      return base::mac::GetUserDirectory(NSCachesDirectory, result);
     case base::DIR_APP_DATA: {
       bool success = base::mac::GetUserDirectory(NSApplicationSupportDirectory,
                                                  result);
 #if defined(OS_IOS)
       // On IOS, this directory does not exist unless it is created explicitly.
       if (success && !file_util::PathExists(*result))
         success = file_util::CreateDirectory(*result);
 #endif  // defined(OS_IOS)
       return success;
     }
@@ skipping 12 matching lines @@
         // src/xcodebuild/{Debug|Release}/Chromium.app/Contents/MacOS/Chromium
         *result = result->DirName().DirName().DirName().DirName().DirName();
       } else {
         // Unit tests execute two levels deep from the source root, eg:
         // src/xcodebuild/{Debug|Release}/base_unittests
         *result = result->DirName().DirName();
       }
 #endif
       return true;
     }
+    case base::DIR_USER_DESKTOP: {
+      return base::mac::GetUserDirectory(NSDesktopDirectory, result);
+    }
+    case base::DIR_CACHE:

[brettw, 2012/09/14 22:10:06]

I'd use {} here to be more in-line with the surrounding code (I realize this
whole switch is a bit inconsistent).

[gab, 2012/09/16 03:13:51]

Done (and made the file uniformly respect this syntax).

+      return base::mac::GetUserDirectory(NSCachesDirectory, result);
     case base::DIR_HOME: {
       *result = base::mac::NSStringToFilePath(NSHomeDirectory());
       return true;
     }
     default:
       return false;
   }
 }
 
 }  // namespace base