OLD | NEW |
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "base/path_service.h" | 5 #include "base/path_service.h" |
6 | 6 |
7 #include "base/basictypes.h" | 7 #include "base/basictypes.h" |
8 #include "base/file_util.h" | 8 #include "base/file_util.h" |
9 #include "base/file_path.h" | 9 #include "base/file_path.h" |
10 #include "base/scoped_temp_dir.h" | 10 #include "base/scoped_temp_dir.h" |
11 #if defined(OS_WIN) | 11 #include "build/build_config.h" |
12 #include "base/win/windows_version.h" | |
13 #endif | |
14 #include "testing/gtest/include/gtest/gtest.h" | 12 #include "testing/gtest/include/gtest/gtest.h" |
15 #include "testing/gtest/include/gtest/gtest-spi.h" | 13 #include "testing/gtest/include/gtest/gtest-spi.h" |
16 #include "testing/platform_test.h" | 14 #include "testing/platform_test.h" |
17 | 15 |
| 16 #if defined(OS_WIN) |
| 17 #include "base/base_paths_win.h" |
| 18 #include "base/win/windows_version.h" |
| 19 #elif defined(OS_POSIX) |
| 20 #include "base/base_paths_posix.h" |
| 21 #endif |
| 22 |
18 namespace { | 23 namespace { |
19 | 24 |
20 // Returns true if PathService::Get returns true and sets the path parameter | 25 // Returns true if PathService::Get returns true and sets the path parameter |
21 // to non-empty for the given PathService::DirType enumeration value. | 26 // to non-empty for the given PathService::DirType enumeration value. |
22 bool ReturnsValidPath(int dir_type) { | 27 bool ReturnsValidPath(int dir_type) { |
23 FilePath path; | 28 FilePath path; |
24 bool result = PathService::Get(dir_type, &path); | 29 bool result = PathService::Get(dir_type, &path); |
25 #if defined(OS_POSIX) | 30 #if defined(OS_POSIX) |
26 // If chromium has never been started on this account, the cache path may not | 31 // If chromium has never been started on this account, the cache path may not |
27 // exist. | 32 // exist. |
28 if (dir_type == base::DIR_CACHE) | 33 if (dir_type == base::DIR_CACHE) |
29 return result && !path.value().empty(); | 34 return result && !path.empty(); |
30 #endif | 35 #endif |
31 return result && !path.value().empty() && file_util::PathExists(path); | 36 #if defined(OS_LINUX) |
| 37 // On the linux try-bots: a path is returned (e.g. /home/chrome-bot/Desktop), |
| 38 // but it doesn't exist. |
| 39 if (dir_type == base::DIR_USER_DESKTOP) |
| 40 return result && !path.empty(); |
| 41 #endif |
| 42 return result && !path.empty() && file_util::PathExists(path); |
32 } | 43 } |
33 | 44 |
34 #if defined(OS_WIN) | 45 #if defined(OS_WIN) |
35 // Function to test any directory keys that are not supported on some versions | 46 // Function to test any directory keys that are not supported on some versions |
36 // of Windows. Checks that the function fails and that the returned path is | 47 // of Windows. Checks that the function fails and that the returned path is |
37 // empty. | 48 // empty. |
38 bool ReturnsInvalidPath(int dir_type) { | 49 bool ReturnsInvalidPath(int dir_type) { |
39 FilePath path; | 50 FilePath path; |
40 bool result = PathService::Get(dir_type, &path); | 51 bool result = PathService::Get(dir_type, &path); |
41 return !result && path.empty(); | 52 return !result && path.empty(); |
42 } | 53 } |
43 #endif | 54 #endif |
44 | 55 |
45 } // namespace | 56 } // namespace |
46 | 57 |
47 // On the Mac this winds up using some autoreleased objects, so we need to | 58 // On the Mac this winds up using some autoreleased objects, so we need to |
48 // be a PlatformTest. | 59 // be a PlatformTest. |
49 typedef PlatformTest PathServiceTest; | 60 typedef PlatformTest PathServiceTest; |
50 | 61 |
51 // Test that all PathService::Get calls return a value and a true result | 62 // Test that all PathService::Get calls return a value and a true result |
52 // in the development environment. (This test was created because a few | 63 // in the development environment. (This test was created because a few |
53 // later changes to Get broke the semantics of the function and yielded the | 64 // later changes to Get broke the semantics of the function and yielded the |
54 // correct value while returning false.) | 65 // correct value while returning false.) |
55 TEST_F(PathServiceTest, Get) { | 66 TEST_F(PathServiceTest, Get) { |
56 for (int key = base::DIR_CURRENT; key < base::PATH_END; ++key) { | 67 for (int key = base::PATH_START + 1; key < base::PATH_END; ++key) { |
57 #if defined(OS_ANDROID) | 68 #if defined(OS_ANDROID) |
58 if (key == base::FILE_MODULE) | 69 if (key == base::FILE_MODULE || key == base::DIR_USER_DESKTOP) |
59 continue; // Android doesn't implement FILE_MODULE; | 70 continue; // Android doesn't implement FILE_MODULE and DIR_USER_DESKTOP; |
60 #endif | 71 #endif |
61 EXPECT_PRED1(ReturnsValidPath, key); | 72 EXPECT_PRED1(ReturnsValidPath, key); |
62 } | 73 } |
63 #if defined(OS_WIN) | 74 #if defined(OS_WIN) |
64 for (int key = base::PATH_WIN_START + 1; key < base::PATH_WIN_END; ++key) { | 75 for (int key = base::PATH_WIN_START + 1; key < base::PATH_WIN_END; ++key) { |
65 bool valid = true; | 76 bool valid = true; |
66 switch(key) { | 77 switch(key) { |
67 case base::DIR_LOCAL_APP_DATA_LOW: | 78 case base::DIR_LOCAL_APP_DATA_LOW: |
68 // DIR_LOCAL_APP_DATA_LOW is not supported prior Vista and is expected | 79 // DIR_LOCAL_APP_DATA_LOW is not supported prior Vista and is expected |
69 // to fail. | 80 // to fail. |
70 valid = base::win::GetVersion() >= base::win::VERSION_VISTA; | 81 valid = base::win::GetVersion() >= base::win::VERSION_VISTA; |
71 break; | 82 break; |
72 case base::DIR_APP_SHORTCUTS: | 83 case base::DIR_APP_SHORTCUTS: |
73 // DIR_APP_SHORTCUTS is not supported prior Windows 8 and is expected to | 84 // DIR_APP_SHORTCUTS is not supported prior Windows 8 and is expected to |
74 // fail. | 85 // fail. |
75 valid = base::win::GetVersion() >= base::win::VERSION_WIN8; | 86 valid = base::win::GetVersion() >= base::win::VERSION_WIN8; |
76 break; | 87 break; |
77 } | 88 } |
78 | 89 |
79 if (valid) | 90 if (valid) |
80 EXPECT_TRUE(ReturnsValidPath(key)) << key; | 91 EXPECT_TRUE(ReturnsValidPath(key)) << key; |
81 else | 92 else |
82 EXPECT_TRUE(ReturnsInvalidPath(key)) << key; | 93 EXPECT_TRUE(ReturnsInvalidPath(key)) << key; |
83 } | 94 } |
84 #elif defined(OS_MACOSX) | 95 #elif defined(OS_MACOSX) |
85 for (int key = base::PATH_MAC_START + 1; key < base::PATH_MAC_END; ++key) { | 96 for (int key = base::PATH_MAC_START + 1; key < base::PATH_MAC_END; ++key) { |
86 EXPECT_PRED1(ReturnsValidPath, key); | 97 EXPECT_PRED1(ReturnsValidPath, key); |
| 98 } |
| 99 #elif defined(OS_ANDROID) |
| 100 for (int key = base::PATH_ANDROID_START + 1; key < base::PATH_ANDROID_END; |
| 101 ++key) { |
| 102 EXPECT_PRED1(ReturnsValidPath, key); |
| 103 } |
| 104 #elif defined(OS_POSIX) |
| 105 for (int key = base::PATH_POSIX_START + 1; key < base::PATH_POSIX_END; |
| 106 ++key) { |
| 107 EXPECT_PRED1(ReturnsValidPath, key); |
87 } | 108 } |
88 #endif | 109 #endif |
89 } | 110 } |
90 | 111 |
91 // test that all versions of the Override function of PathService do what they | 112 // test that all versions of the Override function of PathService do what they |
92 // are supposed to do. | 113 // are supposed to do. |
93 TEST_F(PathServiceTest, Override) { | 114 TEST_F(PathServiceTest, Override) { |
94 int my_special_key = 666; | 115 int my_special_key = 666; |
95 ScopedTempDir temp_dir; | 116 ScopedTempDir temp_dir; |
96 ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); | 117 ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); |
97 FilePath fake_cache_dir(temp_dir.path().AppendASCII("cache")); | 118 FilePath fake_cache_dir(temp_dir.path().AppendASCII("cache")); |
98 // PathService::Override should always create the path provided if it doesn't | 119 // PathService::Override should always create the path provided if it doesn't |
99 // exist. | 120 // exist. |
100 EXPECT_TRUE(PathService::Override(my_special_key, fake_cache_dir)); | 121 EXPECT_TRUE(PathService::Override(my_special_key, fake_cache_dir)); |
101 EXPECT_TRUE(file_util::PathExists(fake_cache_dir)); | 122 EXPECT_TRUE(file_util::PathExists(fake_cache_dir)); |
102 | 123 |
103 FilePath fake_cache_dir2(temp_dir.path().AppendASCII("cache2")); | 124 FilePath fake_cache_dir2(temp_dir.path().AppendASCII("cache2")); |
104 // PathService::OverrideAndCreateIfNeeded should obey the |create| parameter. | 125 // PathService::OverrideAndCreateIfNeeded should obey the |create| parameter. |
105 PathService::OverrideAndCreateIfNeeded(my_special_key, | 126 PathService::OverrideAndCreateIfNeeded(my_special_key, |
106 fake_cache_dir2, | 127 fake_cache_dir2, |
107 false); | 128 false); |
108 EXPECT_FALSE(file_util::PathExists(fake_cache_dir2)); | 129 EXPECT_FALSE(file_util::PathExists(fake_cache_dir2)); |
109 EXPECT_TRUE(PathService::OverrideAndCreateIfNeeded(my_special_key, | 130 EXPECT_TRUE(PathService::OverrideAndCreateIfNeeded(my_special_key, |
110 fake_cache_dir2, | 131 fake_cache_dir2, |
111 true)); | 132 true)); |
112 EXPECT_TRUE(file_util::PathExists(fake_cache_dir2)); | 133 EXPECT_TRUE(file_util::PathExists(fake_cache_dir2)); |
113 } | 134 } |
OLD | NEW |