Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: base/base_paths_win.cc

Issue 10910209: Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adjust links to pass presubmit Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/base_paths_win.h ('k') | base/path_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/base_paths_win.h"
6 5
7 #include <windows.h> 6 #include <windows.h>
8 #include <shlobj.h> 7 #include <shlobj.h>
9 8
9 #include "base/base_paths.h"
10 #include "base/file_path.h" 10 #include "base/file_path.h"
11 #include "base/file_util.h" 11 #include "base/file_util.h"
12 #include "base/path_service.h" 12 #include "base/path_service.h"
13 #include "base/win/scoped_co_mem.h" 13 #include "base/win/scoped_co_mem.h"
14 #include "base/win/windows_version.h" 14 #include "base/win/windows_version.h"
15 15
16 // http://blogs.msdn.com/oldnewthing/archive/2004/10/25/247180.aspx 16 // http://blogs.msdn.com/oldnewthing/archive/2004/10/25/247180.aspx
17 extern "C" IMAGE_DOS_HEADER __ImageBase; 17 extern "C" IMAGE_DOS_HEADER __ImageBase;
18 18
19 namespace {
20
21 bool GetQuickLaunchPath(bool default_user, FilePath* result) {
22 if (default_user) {
23 wchar_t system_buffer[MAX_PATH];
24 system_buffer[0] = 0;
25 // As per MSDN, passing -1 for |hToken| indicates the Default user:
26 // http://msdn.microsoft.com/library/windows/desktop/bb762181.aspx
27 if (FAILED(SHGetFolderPath(NULL, CSIDL_APPDATA,
28 reinterpret_cast<HANDLE>(-1), SHGFP_TYPE_CURRENT,
29 system_buffer))) {
30 return false;
31 }
32 *result = FilePath(system_buffer);
33 } else if (!PathService::Get(base::DIR_APP_DATA, result)) {
34 // For the current user, grab the APPDATA directory directly from the
35 // PathService cache.
36 return false;
37 }
38 // According to various sources, appending
39 // "Microsoft\Internet Explorer\Quick Launch" to %appdata% is the only
40 // reliable way to get the quick launch folder across all versions of Windows.
41 // http://stackoverflow.com/questions/76080/how-do-you-reliably-get-the-quick-
42 // http://www.microsoft.com/technet/scriptcenter/resources/qanda/sept05/hey090 1.mspx
43 *result = result->AppendASCII("Microsoft");
44 *result = result->AppendASCII("Internet Explorer");
45 *result = result->AppendASCII("Quick Launch");
46 return true;
47 }
48
49 } // namespace
50
19 namespace base { 51 namespace base {
20 52
21 bool PathProviderWin(int key, FilePath* result) { 53 bool PathProviderWin(int key, FilePath* result) {
22 54
23 // We need to go compute the value. It would be nice to support paths with 55 // We need to go compute the value. It would be nice to support paths with
24 // names longer than MAX_PATH, but the system functions don't seem to be 56 // names longer than MAX_PATH, but the system functions don't seem to be
25 // designed for it either, with the exception of GetTempPath (but other 57 // designed for it either, with the exception of GetTempPath (but other
26 // things will surely break if the temp path is too long, so we don't bother 58 // things will surely break if the temp path is too long, so we don't bother
27 // handling it. 59 // handling it.
28 wchar_t system_buffer[MAX_PATH]; 60 wchar_t system_buffer[MAX_PATH];
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 return false; 128 return false;
97 cur = FilePath(system_buffer); 129 cur = FilePath(system_buffer);
98 break; 130 break;
99 case base::DIR_PROFILE: 131 case base::DIR_PROFILE:
100 if (FAILED(SHGetFolderPath(NULL, CSIDL_PROFILE, NULL, SHGFP_TYPE_CURRENT, 132 if (FAILED(SHGetFolderPath(NULL, CSIDL_PROFILE, NULL, SHGFP_TYPE_CURRENT,
101 system_buffer))) 133 system_buffer)))
102 return false; 134 return false;
103 cur = FilePath(system_buffer); 135 cur = FilePath(system_buffer);
104 break; 136 break;
105 case base::DIR_LOCAL_APP_DATA_LOW: 137 case base::DIR_LOCAL_APP_DATA_LOW:
106 if (win::GetVersion() < win::VERSION_VISTA) { 138 if (win::GetVersion() < win::VERSION_VISTA)
107 return false; 139 return false;
108 } 140
109 // TODO(nsylvain): We should use SHGetKnownFolderPath instead. Bug 1281128 141 // TODO(nsylvain): We should use SHGetKnownFolderPath instead. Bug 1281128
110 if (FAILED(SHGetFolderPath(NULL, CSIDL_APPDATA, NULL, SHGFP_TYPE_CURRENT, 142 if (FAILED(SHGetFolderPath(NULL, CSIDL_APPDATA, NULL, SHGFP_TYPE_CURRENT,
111 system_buffer))) 143 system_buffer)))
112 return false; 144 return false;
113 cur = FilePath(system_buffer).DirName().AppendASCII("LocalLow"); 145 cur = FilePath(system_buffer).DirName().AppendASCII("LocalLow");
114 break; 146 break;
115 case base::DIR_LOCAL_APP_DATA: 147 case base::DIR_LOCAL_APP_DATA:
116 if (FAILED(SHGetFolderPath(NULL, CSIDL_LOCAL_APPDATA, NULL, 148 if (FAILED(SHGetFolderPath(NULL, CSIDL_LOCAL_APPDATA, NULL,
117 SHGFP_TYPE_CURRENT, system_buffer))) 149 SHGFP_TYPE_CURRENT, system_buffer)))
118 return false; 150 return false;
(...skipping 12 matching lines...) Expand all
131 return false; 163 return false;
132 164
133 base::win::ScopedCoMem<wchar_t> path_buf; 165 base::win::ScopedCoMem<wchar_t> path_buf;
134 if (FAILED(SHGetKnownFolderPath(FOLDERID_ApplicationShortcuts, 0, NULL, 166 if (FAILED(SHGetKnownFolderPath(FOLDERID_ApplicationShortcuts, 0, NULL,
135 &path_buf))) 167 &path_buf)))
136 return false; 168 return false;
137 169
138 cur = FilePath(string16(path_buf)); 170 cur = FilePath(string16(path_buf));
139 break; 171 break;
140 } 172 }
173 case base::DIR_USER_DESKTOP:
174 if (FAILED(SHGetFolderPath(NULL, CSIDL_DESKTOPDIRECTORY, NULL,
175 SHGFP_TYPE_CURRENT, system_buffer))) {
176 return false;
177 }
178 cur = FilePath(system_buffer);
179 break;
180 case base::DIR_COMMON_DESKTOP:
181 if (FAILED(SHGetFolderPath(NULL, CSIDL_COMMON_DESKTOPDIRECTORY, NULL,
182 SHGFP_TYPE_CURRENT, system_buffer))) {
183 return false;
184 }
185 cur = FilePath(system_buffer);
186 break;
187 case base::DIR_USER_QUICK_LAUNCH:
188 if (!GetQuickLaunchPath(false, &cur))
189 return false;
190 break;
191 case base::DIR_DEFAULT_USER_QUICK_LAUNCH:
192 if (!GetQuickLaunchPath(true, &cur))
193 return false;
194 break;
141 default: 195 default:
142 return false; 196 return false;
143 } 197 }
144 198
145 *result = cur; 199 *result = cur;
146 return true; 200 return true;
147 } 201 }
148 202
149 } // namespace base 203 } // namespace base
OLDNEW
« no previous file with comments | « base/base_paths_win.h ('k') | base/path_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698