Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4876)

Unified Diff: chrome/browser/extensions/api/content_settings/content_settings_api.cc

Issue 10910168: Separate plugin_metadata from plugin_installer, thread-safe plugin_finder (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: .. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/content_settings/content_settings_api.cc
diff --git a/chrome/browser/extensions/api/content_settings/content_settings_api.cc b/chrome/browser/extensions/api/content_settings/content_settings_api.cc
index 770569f67a00fc6d1b24b2030676bc7212b1a19c..d4c25d663144ef7de51ee0e7aa690b03142b785e 100644
--- a/chrome/browser/extensions/api/content_settings/content_settings_api.cc
+++ b/chrome/browser/extensions/api/content_settings/content_settings_api.cc
@@ -259,32 +259,30 @@ bool GetResourceIdentifiersFunction::RunImpl() {
}
if (!g_testing_plugins_) {
- PluginFinder::GetPluginsAndPluginFinder(
+ PluginService::GetInstance()->GetPlugins(
base::Bind(&GetResourceIdentifiersFunction::OnGotPlugins, this));
} else {
- PluginFinder::Get(
- base::Bind(&GetResourceIdentifiersFunction::OnGotPlugins, this,
- *g_testing_plugins_));
+ OnGotPlugins(*g_testing_plugins_);
}
return true;
}
void GetResourceIdentifiersFunction::OnGotPlugins(
- const std::vector<webkit::WebPluginInfo>& plugins,
- PluginFinder* finder) {
+ const std::vector<webkit::WebPluginInfo>& plugins) {
+ PluginFinder* finder = PluginFinder::GetInstance();
std::set<std::string> group_identifiers;
ListValue* list = new ListValue();
for (std::vector<webkit::WebPluginInfo>::const_iterator it = plugins.begin();
it != plugins.end(); ++it) {
- PluginInstaller* installer = finder->GetPluginInstaller(*it);
- const std::string& group_identifier = installer->identifier();
+ PluginMetadata* plugin_metadata = finder->GetPluginMetadata(*it);
+ const std::string& group_identifier = plugin_metadata->identifier();
if (group_identifiers.find(group_identifier) != group_identifiers.end())
continue;
group_identifiers.insert(group_identifier);
DictionaryValue* dict = new DictionaryValue();
dict->SetString(keys::kIdKey, group_identifier);
- dict->SetString(keys::kDescriptionKey, installer->name());
+ dict->SetString(keys::kDescriptionKey, plugin_metadata->name());
list->Append(dict);
}
SetResult(list);
« no previous file with comments | « chrome/browser/extensions/api/content_settings/content_settings_api.h ('k') | chrome/browser/plugins/plugin_finder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698