native_client_sdk/PRESUBMIT.py - Issue 10910101: fix pylint warnings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: native_client_sdk/PRESUBMIT.py

Issue 10910101: fix pylint warnings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Top-level presubmit script for isolate.	5 """Top-level presubmit script for isolate.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for

8 details on the presubmit API built into gcl.	8 details on the presubmit API built into gcl.

9 """	9 """

10	10

11	11

12 def CommonChecks(input_api, output_api):	12 def CommonChecks(input_api, output_api):

13 output = []	13 output = []

14 disabled_warnings = [	14 disabled_warnings = [

15 'F0401', # Unable to import module	15 'F0401', # Unable to import module

16 'R0401', # Cyclic import	16 'R0401', # Cyclic import

17 'W0613', # Unused argument	17 'W0613', # Unused argument

18 'E1103', # subprocess.communicate() generates these :(	18 'E1103', # subprocess.communicate() generates these :(

	19 'R0201', # method could be function (doesn't reference self)

19 ]	20 ]

20 black_list = [r'src/build_tools/tests/.*']	21 black_list = [r'src/build_tools/tests/.*',

	22 r'src/site_scons/.*',

	23 ]

21 canned = input_api.canned_checks	24 canned = input_api.canned_checks

22 output.extend(canned.RunPylint(input_api, output_api, black_list=black_list,	25 output.extend(canned.RunPylint(input_api, output_api, black_list=black_list,

23 disabled_warnings=disabled_warnings))	26 disabled_warnings=disabled_warnings))

24 return output	27 return output

25	28

26	29

27 def CheckChangeOnUpload(input_api, output_api):	30 def CheckChangeOnUpload(input_api, output_api):

28 return CommonChecks(input_api, output_api)	31 return CommonChecks(input_api, output_api)

29	32

30	33

31 def CheckChangeOnCommit(input_api, output_api):	34 def CheckChangeOnCommit(input_api, output_api):

32 return CommonChecks(input_api, output_api)	35 return CommonChecks(input_api, output_api)

OLD	NEW

« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/build_sdk.py » ('j') | native_client_sdk/src/build_tools/manifest_util.py » ('J')