Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10910101: fix pylint warnings (Closed)

Created:
8 years, 3 months ago by Sam Clegg
Modified:
8 years, 3 months ago
Reviewers:
noelallen1, binji
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -1060 lines) Patch
M native_client_sdk/PRESUBMIT.py View 1 1 chunk +5 lines, -16 lines 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/build_updater.py View 3 chunks +3 lines, -5 lines 0 comments Download
M native_client_sdk/src/build_tools/build_utils.py View 3 chunks +8 lines, -7 lines 0 comments Download
M native_client_sdk/src/build_tools/buildbot_common.py View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/generate_make.py View 11 chunks +17 lines, -27 lines 0 comments Download
M native_client_sdk/src/build_tools/manifest_util.py View 1 7 chunks +11 lines, -9 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_tools/sdk_update.py View 3 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py View 5 chunks +7 lines, -5 lines 0 comments Download
D native_client_sdk/src/build_tools/sdk_tools/update_manifest.py View 1 chunk +0 lines, -463 lines 0 comments Download
M native_client_sdk/src/build_tools/tests/test_all.py View 1 1 chunk +1 line, -1 line 0 comments Download
D native_client_sdk/src/build_tools/tests/test_update_manifest.py View 1 chunk +0 lines, -523 lines 0 comments Download
A + native_client_sdk/src/build_tools/tests/test_update_nacl_manifest.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M native_client_sdk/src/build_tools/update_nacl_manifest.py View 5 chunks +6 lines, -1 line 0 comments Download
M native_client_sdk/src/project_templates/init_project.py View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/project_templates/init_project_test.py View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sam Clegg
Decided to fix the lint warnings.
8 years, 3 months ago (2012-09-05 23:35:17 UTC) #1
binji
lgtm, just make sure to add back in test_update_manifest. It is actually used! Maybe rename ...
8 years, 3 months ago (2012-09-08 17:45:13 UTC) #2
Sam Clegg
http://codereview.chromium.org/10910101/diff/6001/native_client_sdk/src/build_tools/manifest_util.py File native_client_sdk/src/build_tools/manifest_util.py (right): http://codereview.chromium.org/10910101/diff/6001/native_client_sdk/src/build_tools/manifest_util.py#newcode274 native_client_sdk/src/build_tools/manifest_util.py:274: for key in self: On 2012/09/08 17:45:13, binji wrote: ...
8 years, 3 months ago (2012-09-10 17:19:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/10910101/8001
8 years, 3 months ago (2012-09-10 18:40:22 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-10 20:47:22 UTC) #5 
Change committed as 155820

Powered by Google App Engine
This is Rietveld 408576698