The 'test' command is not always usable on android

build/android/pylib/android_commands.py

Index: build/android/pylib/android_commands.py
diff --git a/build/android/pylib/android_commands.py b/build/android/pylib/android_commands.py
index c6da8e5b6032b848f66a643f1177022b92f1a539..1f30e2f046854e349efa5f0c3c38e66a2439ae48 100644
--- a/build/android/pylib/android_commands.py
+++ b/build/android/pylib/android_commands.py
@@ -1011,7 +1011,14 @@ class AndroidCommands(object):
     assert '"' not in file_name, 'file_name cannot contain double quotes'
     status = self._adb.SendShellCommand(
         '\'test -f "%s"; echo $?\'' % (file_name))
-    return int(status) == 0
+    if not status[0].find('test: not found'):

[Isaac (away), 2012/09/07 01:02:38]

This seems overly protective, can we just assume the test command will exist on
the device?

[yongsheng, 2012/09/07 01:07:05]

I run this on emulators for ARM and x86, both of them don't have this kind of
'test' command.

[yongsheng, 2012/09/07 01:28:08]

See the error in emulators:
invalid literal for int() with base 10: 'test: not found\r\n127\r\n'

+      return int(status) == 0
+
+    status = self._adb.SendShellCommand('ls "%s"' % (file_name))
+    if not status[0].find('No such file or directory'):

[Isaac (away), 2012/09/07 01:02:38]

change to:

'No such file or directory' not in status[0]

[yongsheng, 2012/09/07 01:07:05]

So below patch is also for this issue. Need I change it here? 
http://codereview.chromium.org/10930002

[Isaac (away), 2012/09/10 01:48:45]

That patch wasn't landed (it's going to be abandoned).  Instead, we reverted
this one.

You'll need to make a new CL if you want to reland.

+      return True
+
+    return False
 
   def RunMonkey(self, package_name, category=None, throttle=100, seed=None,
                 event_count=10000, verbosity=1, extra_args=''):