Extract abstract base to API directory for ProfileSyncService.

chrome/browser/api/sync/profile_sync_service_base.h

Index: chrome/browser/api/sync/profile_sync_service_base.h
diff --git a/chrome/browser/api/sync/profile_sync_service_base.h b/chrome/browser/api/sync/profile_sync_service_base.h
new file mode 100644
index 0000000000000000000000000000000000000000..6592fd3dbe2174c91ecefc51e6c0ab18814965bc
--- /dev/null
+++ b/chrome/browser/api/sync/profile_sync_service_base.h
@@ -0,0 +1,47 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_API_SYNC_PROFILE_SYNC_SERVICE_BASE_H_
+#define CHROME_BROWSER_API_SYNC_PROFILE_SYNC_SERVICE_BASE_H_
+
+#include "chrome/browser/api/sync/profile_sync_service_observer.h"
+#include "sync/internal_api/public/base/model_type.h"
+
+namespace content {
+class BrowserContext;
+}
+
+// Abstract base for ProfileSyncService.

[tim (not reviewing), 2012/09/06 17:00:06]

This is intended to remain a pure interface definition, right?  And not actually
be abstract / contain code?

[Jói, 2012/09/06 20:08:35]

Correct.  Changed the comment to just "API for ProfileSyncService."

+class ProfileSyncServiceBase {

[tim (not reviewing), 2012/09/06 17:00:06]

What's the plan with OWNERS for this file?  As long as only pure virtual methods
are added, I guess it's not a big deal since we'll need to approve the
corresponding chrome/browser/sync change.

[Jói, 2012/09/06 20:08:35]

Whoops, copied the OWNERS file from chrome/browser/sync, that is what we
generally do for subdirs of api.

+ public:
+  // Retrieve the sync service to use in the given context.
+  // Returns NULL if sync is not enabled for the context.
+  static ProfileSyncServiceBase* ForContext(content::BrowserContext* context);
+
+  typedef ProfileSyncServiceObserver Observer;
+
+  virtual ~ProfileSyncServiceBase() {}
+
+  // Whether sync is enabled by user or not.
+  virtual bool HasSyncSetupCompleted() const = 0;
+
+  // Returns whether processing changes is allowed.  Check this before doing
+  // any model-modifying operations.
+  virtual bool ShouldPushChanges() = 0;
+
+  // Get the set of currently enabled data types (as chosen or configured by
+  // the user).  See class comment for more on what it means for a datatype

[tim (not reviewing), 2012/09/06 17:00:06]

class comment on ProfileSyncService...

[Jói, 2012/09/06 20:08:35]

Done.

+  // to be Preferred.
+  virtual syncer::ModelTypeSet GetPreferredDataTypes() const = 0;
+
+  // Adds/removes an observer. ProfileSyncService does not take ownership of
+  // the observer.
+  virtual void AddObserver(Observer* observer) = 0;
+  virtual void RemoveObserver(Observer* observer) = 0;
+
+  // Returns true if |observer| has already been added as an observer.
+  virtual bool HasObserver(Observer* observer) const = 0;
+};
+
+#endif  // CHROME_BROWSER_API_SYNC_PROFILE_SYNC_SERVICE_BASE_H_