Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8892)

Unified Diff: chrome/browser/autofill/DEPS

Issue 10910071: Extract abstract base to API directory for ProfileSyncService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More unit test fixes. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/DEPS
diff --git a/chrome/browser/autofill/DEPS b/chrome/browser/autofill/DEPS
index 98ff28afab76880344053023399ea59f94483770..f0c5287a54f5455273c4c470b7699a20f8da1f16 100644
--- a/chrome/browser/autofill/DEPS
+++ b/chrome/browser/autofill/DEPS
@@ -15,9 +15,6 @@ include_rules = [
# Do not add to the list of temporarily-allowed dependencies below,
# and please do not introduce more #includes of these files.
- # Can go once ProfileSyncService is converted.
- "!chrome/browser/profiles/profile.h",
-
# Moving to api
"!chrome/browser/profiles/profile_keyed_service.h",
@@ -25,11 +22,6 @@ include_rules = [
"!chrome/browser/profiles/profile_dependency_manager.h",
"!chrome/browser/profiles/profile_keyed_service_factory.h",
- # Needs abstract base.
- "!chrome/browser/sync/profile_sync_service.h",
- "!chrome/browser/sync/profile_sync_service_factory.h",
- "!chrome/browser/sync/profile_sync_service_observer.h",
-
"!chrome/browser/ui/tab_contents/tab_contents.h",
# Do not add to the list of temporarily-allowed dependencies above,
@@ -46,6 +38,9 @@ specific_include_rules = {
# and please do not introduce more #includes of these files.
'.*_[a-z]*test\.cc': [
"!chrome/browser/password_manager/encryptor.h",
+ "!chrome/browser/profiles/profile.h",
+ "!chrome/browser/sync/profile_sync_service.h",
+ "!chrome/browser/sync/profile_sync_service_factory.h",
"!chrome/browser/translate/translate_infobar_delegate.h",
"!chrome/browser/translate/translate_manager.h",
"!chrome/browser/webdata/autofill_web_data_service_impl.h",
@@ -59,9 +54,10 @@ specific_include_rules = {
"!chrome/browser/ui/tab_contents/test_tab_contents.h",
],
- # TODO(joi): Get rid of the need for this, e.g. by moving
+ # TODO(joi): Get rid of the need for this by moving
# PersonalDataManagerFactory to chrome/browser/configuration.
'personal_data_manager_factory\.cc': [
+ "!chrome/browser/profiles/profile.h",
"!chrome/browser/webdata/web_data_service_factory.h",
],
}

Powered by Google App Engine
This is Rietveld 408576698