Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9059)

Unified Diff: chrome/renderer/chrome_content_renderer_client_unittest.cc

Issue 10910004: Disable ChromeContentRendererClientTest.NaClRestriction on ARM. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Added bug ID to TODOs Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client_unittest.cc
diff --git a/chrome/renderer/chrome_content_renderer_client_unittest.cc b/chrome/renderer/chrome_content_renderer_client_unittest.cc
index 3283b3957c703a605aa6b90f62c6992564d39b12..cbba28f33e097d568fe7337d51a7906f24353109 100644
--- a/chrome/renderer/chrome_content_renderer_client_unittest.cc
+++ b/chrome/renderer/chrome_content_renderer_client_unittest.cc
@@ -62,6 +62,12 @@ void AddContentTypeHandler(WebPluginInfo* info,
typedef testing::Test ChromeContentRendererClientTest;
+#if !defined(__arm__)
+// The ARM ABI is not quite stable, so we only allow NaCl for
+// unrestricted extensions (i.e. built-in and under development).
+// Disable this whole test for ARM; other ABIs give us content-type coverage.
+// https://code.google.com/p/chromium/issues/detail?id=145694
+// TODO(dschuff): remove this when the ARM ABI is stable
TEST_F(ChromeContentRendererClientTest, NaClRestriction) {
// Unknown content types have no NaCl module.
{
@@ -196,6 +202,7 @@ TEST_F(ChromeContentRendererClientTest, NaClRestriction) {
&params));
}
}
+#endif // !defined(__arm__)
} // namespace chrome

Powered by Google App Engine
This is Rietveld 408576698