chrome/test/data/extensions/api_test/browser_action/basics/manifest.json - Issue 10909256: Always send the full tab object in ExtensionAction click event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/browser_action/basics/manifest.json

Issue 10909256: Always send the full tab object in ExtensionAction click event. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: 'add some tests' Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_tab_util.cc ('K') | « chrome/test/data/extensions/api_test/browser_action/basics/background.js ('k') | chrome/test/data/extensions/api_test/messaging/connect/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/browser_action/basics/manifest.json

diff --git a/chrome/test/data/extensions/api_test/browser_action/basics/manifest.json b/chrome/test/data/extensions/api_test/browser_action/basics/manifest.json

index c9acc109e505261184ae9193acf15b31885bca3b..e67eaa836dfde46713b6580ed1363315b9bb2191 100644

--- a/chrome/test/data/extensions/api_test/browser_action/basics/manifest.json

+++ b/chrome/test/data/extensions/api_test/browser_action/basics/manifest.json

@@ -6,7 +6,7 @@

"scripts": ["background.js"]

"permissions": [

- "tabs", "http://*/*"

+ "http://*/*"

"browser_action": {

"default_title": "Make this page red",