Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Side by Side Diff: chrome/browser/extensions/installed_loader.cc

Issue 10909239: Rename PACKAGED_APP references to LEGACY_PACKAGED_APP (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/installed_loader.h" 5 #include "chrome/browser/extensions/installed_loader.h"
6 6
7 #include "base/file_path.h" 7 #include "base/file_path.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "base/stringprintf.h" 9 #include "base/stringprintf.h"
10 #include "base/threading/thread_restrictions.h" 10 #include "base/threading/thread_restrictions.h"
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 extension_service_->extensions()->size()); 184 extension_service_->extensions()->size());
185 UMA_HISTOGRAM_COUNTS_100("Extensions.Disabled", 185 UMA_HISTOGRAM_COUNTS_100("Extensions.Disabled",
186 extension_service_->disabled_extensions()->size()); 186 extension_service_->disabled_extensions()->size());
187 187
188 UMA_HISTOGRAM_TIMES("Extensions.LoadAllTime", 188 UMA_HISTOGRAM_TIMES("Extensions.LoadAllTime",
189 base::TimeTicks::Now() - start_time); 189 base::TimeTicks::Now() - start_time);
190 190
191 int app_user_count = 0; 191 int app_user_count = 0;
192 int app_external_count = 0; 192 int app_external_count = 0;
193 int hosted_app_count = 0; 193 int hosted_app_count = 0;
194 int packaged_app_count = 0; 194 int legacy_packaged_app_count = 0;
195 int user_script_count = 0; 195 int user_script_count = 0;
196 int extension_user_count = 0; 196 int extension_user_count = 0;
197 int extension_external_count = 0; 197 int extension_external_count = 0;
198 int theme_count = 0; 198 int theme_count = 0;
199 int page_action_count = 0; 199 int page_action_count = 0;
200 int browser_action_count = 0; 200 int browser_action_count = 0;
201 int disabled_for_permissions_count = 0; 201 int disabled_for_permissions_count = 0;
202 const ExtensionSet* extensions = extension_service_->extensions(); 202 const ExtensionSet* extensions = extension_service_->extensions();
203 ExtensionSet::const_iterator ex; 203 ExtensionSet::const_iterator ex;
204 for (ex = extensions->begin(); ex != extensions->end(); ++ex) { 204 for (ex = extensions->begin(); ex != extensions->end(); ++ex) {
(...skipping 29 matching lines...) Expand all
234 ++user_script_count; 234 ++user_script_count;
235 break; 235 break;
236 case Extension::TYPE_HOSTED_APP: 236 case Extension::TYPE_HOSTED_APP:
237 ++hosted_app_count; 237 ++hosted_app_count;
238 if (Extension::IsExternalLocation(location)) { 238 if (Extension::IsExternalLocation(location)) {
239 ++app_external_count; 239 ++app_external_count;
240 } else { 240 } else {
241 ++app_user_count; 241 ++app_user_count;
242 } 242 }
243 break; 243 break;
244 case Extension::TYPE_PACKAGED_APP: 244 case Extension::TYPE_LEGACY_PACKAGED_APP:
245 ++packaged_app_count; 245 ++legacy_packaged_app_count;
246 if (Extension::IsExternalLocation(location)) { 246 if (Extension::IsExternalLocation(location)) {
247 ++app_external_count; 247 ++app_external_count;
248 } else { 248 } else {
249 ++app_user_count; 249 ++app_user_count;
250 } 250 }
251 break; 251 break;
252 case Extension::TYPE_EXTENSION: 252 case Extension::TYPE_EXTENSION:
253 default: 253 default:
254 if (Extension::IsExternalLocation(location)) { 254 if (Extension::IsExternalLocation(location)) {
255 ++extension_external_count; 255 ++extension_external_count;
(...skipping 17 matching lines...) Expand all
273 if (extension_service_->extension_prefs()-> 273 if (extension_service_->extension_prefs()->
274 DidExtensionEscalatePermissions((*ex)->id())) { 274 DidExtensionEscalatePermissions((*ex)->id())) {
275 ++disabled_for_permissions_count; 275 ++disabled_for_permissions_count;
276 } 276 }
277 } 277 }
278 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadApp", 278 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadApp",
279 app_user_count + app_external_count); 279 app_user_count + app_external_count);
280 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadAppUser", app_user_count); 280 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadAppUser", app_user_count);
281 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadAppExternal", app_external_count); 281 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadAppExternal", app_external_count);
282 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadHostedApp", hosted_app_count); 282 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadHostedApp", hosted_app_count);
283 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadPackagedApp", packaged_app_count); 283 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadPackagedApp",
284 legacy_packaged_app_count);
284 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadExtension", 285 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadExtension",
285 extension_user_count + extension_external_count); 286 extension_user_count + extension_external_count);
286 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadExtensionUser", 287 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadExtensionUser",
287 extension_user_count); 288 extension_user_count);
288 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadExtensionExternal", 289 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadExtensionExternal",
289 extension_external_count); 290 extension_external_count);
290 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadUserScript", user_script_count); 291 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadUserScript", user_script_count);
291 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadTheme", theme_count); 292 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadTheme", theme_count);
292 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadPageAction", page_action_count); 293 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadPageAction", page_action_count);
293 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadBrowserAction", 294 UMA_HISTOGRAM_COUNTS_100("Extensions.LoadBrowserAction",
294 browser_action_count); 295 browser_action_count);
295 UMA_HISTOGRAM_COUNTS_100("Extensions.DisabledForPermissions", 296 UMA_HISTOGRAM_COUNTS_100("Extensions.DisabledForPermissions",
296 disabled_for_permissions_count); 297 disabled_for_permissions_count);
297 } 298 }
298 299
299 int InstalledLoader::GetCreationFlags(const ExtensionInfo* info) { 300 int InstalledLoader::GetCreationFlags(const ExtensionInfo* info) {
300 int flags = Extension::NO_FLAGS; 301 int flags = Extension::NO_FLAGS;
301 if (info->extension_location != Extension::LOAD) 302 if (info->extension_location != Extension::LOAD)
302 flags |= Extension::REQUIRE_KEY; 303 flags |= Extension::REQUIRE_KEY;
303 if (extension_prefs_->AllowFileAccess(info->extension_id)) 304 if (extension_prefs_->AllowFileAccess(info->extension_id))
304 flags |= Extension::ALLOW_FILE_ACCESS; 305 flags |= Extension::ALLOW_FILE_ACCESS;
305 if (extension_prefs_->IsFromWebStore(info->extension_id)) 306 if (extension_prefs_->IsFromWebStore(info->extension_id))
306 flags |= Extension::FROM_WEBSTORE; 307 flags |= Extension::FROM_WEBSTORE;
307 if (extension_prefs_->IsFromBookmark(info->extension_id)) 308 if (extension_prefs_->IsFromBookmark(info->extension_id))
308 flags |= Extension::FROM_BOOKMARK; 309 flags |= Extension::FROM_BOOKMARK;
309 return flags; 310 return flags;
310 } 311 }
311 312
312 } // namespace extensions 313 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698