Chromium Code Reviews| Index: ui/views/border.cc |
| diff --git a/ui/views/border.cc b/ui/views/border.cc |
| index 1cfb037d0cece46b08cb0df13bb495d3cb8bdf35..6ea5b3df7f8a4d2e31cb6c4af0956b1dd6fb8bf3 100644 |
| --- a/ui/views/border.cc |
| +++ b/ui/views/border.cc |
| @@ -5,6 +5,7 @@ |
| #include "ui/views/border.h" |
| #include "base/logging.h" |
| +#include "base/memory/scoped_ptr.h" |
| #include "ui/gfx/canvas.h" |
| #include "ui/views/painter.h" |
| @@ -22,7 +23,10 @@ class SidedSolidBorder : public Border { |
| virtual void GetInsets(gfx::Insets* insets) const OVERRIDE; |
| private: |
| - int top_, left_, bottom_, right_; |
| + int top_; |
|
sky
2012/09/17 14:10:27
const
|
| + int left_; |
| + int bottom_; |
| + int right_; |
| SkColor color_; |
| gfx::Insets insets_; |
| @@ -30,7 +34,7 @@ class SidedSolidBorder : public Border { |
| }; |
| SidedSolidBorder::SidedSolidBorder(int top, int left, int bottom, int right, |
|
sky
2012/09/17 14:10:27
each param on its own line.
|
| - SkColor color) |
| + SkColor color) |
| : top_(top), |
| left_(left), |
| bottom_(bottom), |
| @@ -97,14 +101,11 @@ class BorderPainter : public Border { |
| DCHECK(painter); |
| } |
| - virtual ~BorderPainter() { |
| - delete painter_; |
| - painter_ = NULL; |
| - } |
| + virtual ~BorderPainter() {} |
| // Overridden from Border: |
| virtual void Paint(const View& view, gfx::Canvas* canvas) const OVERRIDE { |
| - Painter::PaintPainterAt(canvas, painter_, view.GetLocalBounds()); |
| + Painter::PaintPainterAt(canvas, painter_.get(), view.GetLocalBounds()); |
| } |
| virtual void GetInsets(gfx::Insets* insets) const OVERRIDE { |
| @@ -113,12 +114,12 @@ class BorderPainter : public Border { |
| } |
| private: |
| - Painter* painter_; |
| + scoped_ptr<Painter> painter_; |
| DISALLOW_COPY_AND_ASSIGN(BorderPainter); |
| }; |
| -} // namespace |
| +} // namespace |
| Border::Border() { |
| } |
| @@ -138,12 +139,12 @@ Border* Border::CreateEmptyBorder(int top, int left, int bottom, int right) { |
| // static |
| Border* Border::CreateSolidSidedBorder(int top, int left, |
|
sky
2012/09/17 14:10:27
each param on its own line.
|
| - int bottom, int right, |
| - SkColor color) { |
| + int bottom, int right, |
| + SkColor color) { |
| return new SidedSolidBorder(top, left, bottom, right, color); |
| } |
| -//static |
| +// static |
| Border* Border::CreateBorderPainter(Painter* painter) { |
| return new BorderPainter(painter); |
| } |