Chromium Code Reviews Chromium Code Reviews
Issue 10909189:
Add gyp files to build NSS in Dart (Closed)
Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart| OLD | NEW |
|---|---|
| (Empty) | |
| 1 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file | |
| 2 # for details. All rights reserved. Use of this source code is governed by a | |
| 3 # BSD-style license that can be found in the LICENSE file. | |
| 4 | |
| 5 # This file is included to modify the configurations to build third-party | |
| 6 # code from Mozilla's NSS and NSPR libraries, modified by the Chromium project. | |
| 7 # This code is C code, not C++, and is not warning-free, so we need to remove | |
| 8 # C++-specific flags, and add flags to supress the warnings in the code. | |
| 9 # This file is included from gyp files in the runtime/bin/net directory. | |
| 10 { | |
|
Mads Ager (google)
2012/11/02 13:56:35
Could you add a blank line after the comment?
| |
| 11 'variables': { | |
| 12 # Used by third_party/nss, which is from Chromium. | |
| 13 'os_posix': 1, | |
| 14 'os_bsd': 0, | |
| 15 'chromeos': 0, | |
| 16 'clang': 0, | |
| 17 }, | |
| 18 'target_defaults': { | |
| 19 'cflags': [ | |
| 20 '-Wno-unused-variable', | |
| 21 '-Wno-unused-but-set-variable', | |
| 22 '-Wno-missing-field-initializers', | |
| 23 '-Wno-uninitialized', | |
| 24 '-Wno-sign-compare', | |
| 25 '-Wno-empty-body', | |
| 26 '-Wno-type-limits', | |
| 27 '-Wno-pointer-to-int-cast', | |
| 28 '-UHAVE_CVAR_BUILT_ON_SEM', | |
| 29 ], | |
| 30 # Removes these flags from the list cflags. | |
|
Mads Ager (google)
2012/11/02 13:56:35
Could you group these flags and comment on the ind
| |
| 31 'cflags!': [ | |
| 32 '-Werror', | |
| 33 '-Wall', | |
| 34 '-Wvla', | |
| 35 '-Woverloaded-virtual', | |
| 36 '-ansi', | |
| 37 '-fno-exceptions', | |
| 38 '-fvisibility=hidden', | |
| 39 # Not supported for C, only for C++. | |
| 40 '-Wnon-virtual-dtor', | |
| 41 '-Wno-conversion-null', | |
| 42 '-fno-rtti', | |
| 43 '-fvisibility-inlines-hidden', | |
| 44 ], | |
| 45 'configurations': { | |
| 46 'Dart_Base': { | |
| 47 'xcode_settings': { | |
| 48 'WARNING_CFLAGS!': [ | |
| 49 '-Wall', | |
| 50 '-Wextra', | |
| 51 ], | |
| 52 }, | |
| 53 }, | |
| 54 # Dart_Debug and Dart_Release are merged after Dart_Base, so we can | |
| 55 # override the 'ansi' and '-Werror' flags set at the global level in | |
| 56 # tools/gyp/configurations_xcode.gypi. | |
| 57 'Dart_Debug': { | |
| 58 'xcode_settings': { | |
| 59 # Remove 'ansi' setting. | |
| 60 'GCC_C_LANGUAGE_STANDARD': 'c99', | |
| 61 'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO', # -Werror off | |
| 62 }, | |
| 63 }, | |
| 64 'Dart_Release': { | |
| 65 'xcode_settings': { | |
| 66 # Remove 'ansi' setting. | |
| 67 'GCC_C_LANGUAGE_STANDARD': 'c99', | |
| 68 'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO', # -Werror off | |
| 69 }, | |
| 70 }, | |
| 71 }, | |
| 72 }, | |
| 73 } | |
| OLD | NEW |
