sync: Process client commands on commit response

sync/sessions/sync_session.cc

Index: sync/sessions/sync_session.cc
diff --git a/sync/sessions/sync_session.cc b/sync/sessions/sync_session.cc
index b7bb5ca3c7f40bcf4410fb6e657d87304ad42cc1..ef940dbdd2f0898f56d396ab637de65c1424c6d7 100644
--- a/sync/sessions/sync_session.cc
+++ b/sync/sessions/sync_session.cc
@@ -152,6 +152,24 @@ void SyncSession::PrepareForAnotherSyncCycle() {
   status_controller_.reset(new StatusController(routing_info_));
 }
 
+void SyncSession::ProcessClientCommand(const sync_pb::ClientCommand& command) {

[tim (not reviewing), 2012/09/11 20:08:55]

We have a few "do on every request/response" actions now, and we're handling
most (all?) of them in PostClientToServerMessage. For example,
PersistBagOfChips, delegate()->OnSyncProtocolError(), SetProtocolVersion... etc.
 Could you move this handling to that method?  Whether or not it is the final
resting place for these things, it'd be nice to keep them together at a single
choke point versus maintaining them scattered in each command. 

[rlarocque, 2012/09/11 20:28:55]

Done, sort of.

I moved the call to this function into PostClientToServerMessage.  I left the
definition here.  That was how I interpreted your comment on first reading.  

Did you also want to inline this code into that method?

+  if (command.has_max_commit_batch_size()) {
+    context()->set_max_commit_batch_size(command.max_commit_batch_size());
+  }
+  if (command.has_set_sync_long_poll_interval()) {
+    delegate()->OnReceivedLongPollIntervalUpdate(
+        base::TimeDelta::FromSeconds(command.set_sync_long_poll_interval()));
+  }
+  if (command.has_set_sync_poll_interval()) {
+    delegate()->OnReceivedShortPollIntervalUpdate(
+        base::TimeDelta::FromSeconds(command.set_sync_poll_interval()));
+  }
+  if (command.has_sessions_commit_delay_seconds()) {
+    delegate()->OnReceivedSessionsCommitDelay(
+        base::TimeDelta::FromSeconds(command.sessions_commit_delay_seconds()));
+  }
+}
+
 SyncSessionSnapshot SyncSession::TakeSnapshot() const {
   syncable::Directory* dir = context_->directory();