 Chromium Code Reviews
 Chromium Code Reviews Issue 10909158:
  Add support for building targets directly from gyp.  (Closed) 
  Base URL: http://gyp.googlecode.com/svn/trunk
    
  
    Issue 10909158:
  Add support for building targets directly from gyp.  (Closed) 
  Base URL: http://gyp.googlecode.com/svn/trunk| Index: test/lib/TestGyp.py | 
| diff --git a/test/lib/TestGyp.py b/test/lib/TestGyp.py | 
| index 64edafa49259faef0446e8291316317d43b6467c..07a8e4e32bc942ec782bd368bd25d5b9fef77896 100644 | 
| --- a/test/lib/TestGyp.py | 
| +++ b/test/lib/TestGyp.py | 
| @@ -604,6 +604,14 @@ class TestGypMake(TestGypBase): | 
| return self.workpath(*result) | 
| +def ConvertToCygpath(path): | 
| 
bradn
2012/09/18 00:22:39
Shame its not shared but probably best.
 | 
| + """Convert to cygwin path if we are using cygwin.""" | 
| + if sys.platform == 'cygwin': | 
| + p = subprocess.Popen(["cygpath", path], stdout=subprocess.PIPE) | 
| 
bradn
2012/09/18 00:22:39
single
 
Sam Clegg
2012/09/18 00:47:17
Done.
 | 
| + path = p.communicate()[0].strip() | 
| + return path | 
| + | 
| + | 
| def FindVisualStudioInstallation(): | 
| """Returns appropriate values for .build_tool and .uses_msbuild fields | 
| of TestGypBase for Visual Studio. | 
| @@ -619,6 +627,8 @@ def FindVisualStudioInstallation(): | 
| '2008': r'Microsoft Visual Studio 9.0\Common7\IDE\devenv.com', | 
| '2005': r'Microsoft Visual Studio 8\Common7\IDE\devenv.com'} | 
| + possible_roots = [ConvertToCygpath(r) for r in possible_roots] | 
| + | 
| msvs_version = 'auto' | 
| for flag in (f for f in sys.argv if f.startswith('msvs_version=')): | 
| msvs_version = flag.split('=')[-1] |