autocomplete: Add AutocompleteProvider::Type enum.

chrome/browser/ui/webui/options/home_page_overlay_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/home_page_overlay_handler.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/values.h"
+#include "chrome/browser/autocomplete/autocomplete_classifier.h"
 #include "chrome/browser/autocomplete/autocomplete_controller.h"
 #include "chrome/browser/autocomplete/autocomplete_input.h"
 #include "chrome/browser/autocomplete/autocomplete_result.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/browser/web_ui.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace options {
 
 HomePageOverlayHandler::HomePageOverlayHandler() {
 }
 
 HomePageOverlayHandler::~HomePageOverlayHandler() {
 }
 
 void HomePageOverlayHandler::RegisterMessages() {
   web_ui()->RegisterMessageCallback(
       "requestAutocompleteSuggestionsForHomePage",
       base::Bind(&HomePageOverlayHandler::RequestAutocompleteSuggestions,
                  base::Unretained(this)));
 }
 
 void HomePageOverlayHandler::InitializeHandler() {
   Profile* profile = Profile::FromWebUI(web_ui());
-  autocomplete_controller_.reset(new AutocompleteController(profile, this));
+  autocomplete_controller_.reset(
+      new AutocompleteController(
+          profile,
+          this,
+          AutocompleteClassifier::kDefaultOmniboxProviders));

[Peter Kasting, 2012/09/07 23:23:02]

This file and the other webui/options file probably want to share the same
constant, but I don't know that it should be the "default provider set"
constant.  I think only BUILTIN, the three HISTORY providers, and SEARCH should
be listed here, and SEARCH should have a comment saying we only keep it for
navsuggest results.

[Daniel Erat, 2012/09/08 16:37:36]

I chatted with tbreisacher@google.com about this yesterday.  When I looked at
the list of non-dropped result types in
OptionsUI::ProcessAutocompleteSuggestions() and then looked at which providers
seemed capable of generating them, it ended up being all of them except for the
extension/app provider.  I'd prefer to leave this code as-is, at least within
the scope of this refactoring.

 }
 
 void HomePageOverlayHandler::GetLocalizedValues(
     base::DictionaryValue* localized_strings) {
   RegisterTitle(localized_strings, "homePageOverlay",
                 IDS_OPTIONS_HOMEPAGE_TITLE);
 }
 
 void HomePageOverlayHandler::RequestAutocompleteSuggestions(
     const base::ListValue* args) {
   string16 input;
   CHECK_EQ(args->GetSize(), 1U);
   CHECK(args->GetString(0, &input));
 
   autocomplete_controller_->Start(input, string16(), true, false, false,
                                   AutocompleteInput::ALL_MATCHES);
 }
 
 void HomePageOverlayHandler::OnResultChanged(bool default_match_changed) {
   const AutocompleteResult& result = autocomplete_controller_->result();
   base::ListValue suggestions;
   OptionsUI::ProcessAutocompleteSuggestions(result, &suggestions);
   web_ui()->CallJavascriptFunction(
       "HomePageOverlay.updateAutocompleteSuggestions", suggestions);
 }
 
 }  // namespace options