autocomplete: Add AutocompleteProvider::Type enum.

chrome/browser/autocomplete/autocomplete_provider_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/autocomplete_provider.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/string16.h"
@@ skipping 27 matching lines @@
 const char kTestTemplateURLKeyword[] = "t";
 }
 
 // Autocomplete provider that provides known results. Note that this is
 // refcounted so that it can also be a task on the message loop.
 class TestProvider : public AutocompleteProvider {
  public:
   TestProvider(int relevance, const string16& prefix,
                Profile* profile,
                const string16 match_keyword)
-      : AutocompleteProvider(NULL, profile, ""),
+      : AutocompleteProvider(NULL, profile, AutocompleteProvider::TYPE_SEARCH),

[Daniel Erat, 2012/09/07 21:45:55]

I'm using TYPE_SEARCH pretty arbitrarily here.  Let me know if you'd prefer I
added a TYPE_UNKNOWN, TYPE_TEST, or similar value instead.

[Peter Kasting, 2012/09/07 23:23:02]

This is fine.

         relevance_(relevance),
         prefix_(prefix),
         match_keyword_(match_keyword) {
   }
 
   virtual void Start(const AutocompleteInput& input,
                      bool minimal_changes);
 
   void set_listener(AutocompleteProviderListener* listener) {
     listener_ = listener;
@@ skipping 269 matching lines @@
   keyword_t_url = new TemplateURL(&profile_, data);
   turl_model->Add(keyword_t_url);
   ASSERT_NE(0, keyword_t_url->id());
 
   // Forget about any existing providers.  The controller owns them and will
   // Release() them below, when we delete it during the call to reset().
   providers_.clear();
 
   // Create both a keyword and search provider, and add them in that order.
   // (Order is important; see comments in RunExactKeymatchTest().)
   KeywordProvider* keyword_provider = new KeywordProvider(NULL, &profile_);

[Peter Kasting, 2012/09/07 23:23:02]

I think this block of code can be replaced with a simple construction of
AutocompleteController that you pass KEYWORD_PROVIDER to.  This in turn should
eliminate the need for set_keyword_provider().

[Daniel Erat, 2012/09/08 16:37:36]

Done.  Think I was misled by the comment above ("Create both a keyword and
search provider").

   keyword_provider->AddRef();
   providers_.push_back(keyword_provider);
 
   AutocompleteController* controller =
       new AutocompleteController(providers_, &profile_);
   controller->set_keyword_provider(keyword_provider);
   controller_.reset(controller);
 }
 
 void AutocompleteProviderTest::RunTest() {
@@ skipping 208 matching lines @@
       { AutocompleteMatch::NAVSUGGEST, "chrome.3.57j58j5l2j0l3j59" },
       { AutocompleteMatch::SEARCH_SUGGEST, "chrome.4.57j58j5l2j0l3j59" },
       { AutocompleteMatch::SEARCH_SUGGEST, "chrome.5.57j58j5l2j0l3j59" },
       { AutocompleteMatch::SEARCH_SUGGEST, "chrome.6.57j58j5l2j0l3j59" },
       { AutocompleteMatch::SEARCH_HISTORY, "chrome.7.57j58j5l2j0l3j59" },
     };
     SCOPED_TRACE("Multiple matches");
     RunAssistedQueryStatsTest(test_data, ARRAYSIZE_UNSAFE(test_data));
   }
 }
-