Add butter bar for wallpapaer manager(show downloading progress or error message)

Add butter bar for wallpapaer manager(show downloading progress or error message) 


BUG=146905
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156491

[bshe, 2012-09-07 20:21:01]

Hi Vladislav.

As you suggested in http://codereview.chromium.org/10916149/, I am directly
coping butter bar code to wallpaper manager. Could you please take a look? Note
that all the js strings that I use in the CL is not final. I will create
translated string resources in a follow up CL.

Thanks!

[bshe, 2012-09-11 13:28:17]

friendly ping?

On 2012/09/07 20:21:01, bshe wrote:
> Hi Vladislav.
> 
> As you suggested in http://codereview.chromium.org/10916149/, I am directly
> coping butter bar code to wallpaper manager. Could you please take a look?
Note
> that all the js strings that I use in the CL is not final. I will create
> translated string resources in a follow up CL.
> 
> Thanks!

[Vladislav Kaznacheev, 2012-09-12 13:45:12]

LGTM with nits

https://chromiumcodereview.appspot.com/10909125/diff/7001/chrome/browser/reso...
File chrome/browser/resources/chromeos/wallpaper_manager/js/butter_bar.js
(right):

https://chromiumcodereview.appspot.com/10909125/diff/7001/chrome/browser/reso...
chrome/browser/resources/chromeos/wallpaper_manager/js/butter_bar.js:195: if
(this.xhr_)
Formatting: extra space after this.xhr everywhere in this method.

https://chromiumcodereview.appspot.com/10909125/diff/7001/chrome/browser/reso...
chrome/browser/resources/chromeos/wallpaper_manager/js/butter_bar.js:274: *
@param {ProgressEvent} e A progress ProgressEvent from XMLHttpRequest.
The description does not parse.

[bshe, 2012-09-12 18:48:58]

Thanks for review.

http://codereview.chromium.org/10909125/diff/7001/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/wallpaper_manager/js/butter_bar.js
(right):

http://codereview.chromium.org/10909125/diff/7001/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/wallpaper_manager/js/butter_bar.js:195: if
(this.xhr_)
you mean this.xhr_? I dont think I have an extra space after it. 

On 2012/09/12 13:45:12, Vladislav Kaznacheev wrote:
> Formatting: extra space after this.xhr everywhere in this method.

http://codereview.chromium.org/10909125/diff/7001/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/wallpaper_manager/js/butter_bar.js:274: *
@param {ProgressEvent} e A progress ProgressEvent from XMLHttpRequest.
On 2012/09/12 13:45:12, Vladislav Kaznacheev wrote:
> The description does not parse.

Done.

[commit-bot: I haz the power, 2012-09-12 18:49:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/10909125/7002

[commit-bot: I haz the power, 2012-09-12 19:32:19]

Try job failure for 10909125-7002 (retry) (previous was lost) on linux_chromeos
for step "compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...