Fix resource leaks in CDM implementation.

webkit/media/crypto/ppapi/cdm_wrapper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <cstring>  // For memcpy.
 #include <vector>
 
 #include "base/compiler_specific.h"  // For OVERRIDE.
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/c/pp_stdint.h"
@@ skipping 216 matching lines @@
 
   cdm::OutputBuffer output_buffer;
   cdm::Status status = cdm_->Decrypt(input_buffer, &output_buffer);
 
   CallOnMain(callback_factory_.NewCallback(
       &CdmWrapper::DeliverBlock,
       status,
       output_buffer,
       encrypted_block_info.tracking_info));
 
+  pp::Module::Get()->core()->ReleaseResource(encrypted_buffer.pp_resource());

[dmichael (off chromium), 2012/09/05 17:13:06]

The C++ interface should take care of reference counting for you correctly. If
it doesn't, it's a bug in the C++ wrapper
(ppapi/cpp/private/content_decryptor_private.cc). You can either do
ReleaseResource there, or add a PassRef constructor to pp::BufferDev (see
pp::Resource).

[Tom Finegan, 2012/09/05 19:21:43]

Added a PassRef ctor to pp::BufferDev.

   return true;
 }
 
 bool CdmWrapper::DecryptAndDecode(
     pp::Buffer_Dev encrypted_buffer,
     const PP_EncryptedBlockInfo& encrypted_block_info) {
   return false;
 }
 
 PP_Resource CdmWrapper::MakeBufferResource(const uint8_t* data,
@@ skipping 89 matching lines @@
 }  // namespace webkit_media
 
 namespace pp {
 
 // Factory function for your specialization of the Module object.
 Module* CreateModule() {
   return new webkit_media::MyModule();
 }
 
 }  // namespace pp