Fix resource leaks in CDM implementation.

ppapi/proxy/ppp_content_decryptor_private_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/ppp_content_decryptor_private_proxy.h"
 
 #include "base/platform_file.h"
 #include "ppapi/c/pp_bool.h"
 #include "ppapi/c/ppb_core.h"
 #include "ppapi/proxy/content_decryptor_private_serializer.h"
@@ skipping 122 matching lines @@
     NOTREACHED();
     return PP_FALSE;
   }
   const PPB_Core* core = static_cast<const PPB_Core*>(
       dispatcher->local_get_interface()(PPB_CORE_INTERFACE));
   if (!core) {
     NOTREACHED();
     return PP_FALSE;
   }
 
-  // We need to take a ref on the resource now. The browser may drop
-  // references once we return from here, but we're sending an asynchronous
-  // message. The plugin side takes ownership of that reference.
-  core->AddRefResource(encrypted_block);
-
   HostResource host_resource;
   host_resource.SetHostResource(instance, encrypted_block);
 
   uint32_t size = 0;
   if (DescribeHostBufferResource(encrypted_block, &size) == PP_FALSE)
     return PP_FALSE;
 
   base::SharedMemoryHandle handle;
   if (ShareHostBufferResourceToPlugin(dispatcher,
                                       encrypted_block,
@@ skipping 12 matching lines @@
   return PP_FromBool(dispatcher->Send(
       new PpapiMsg_PPPContentDecryptor_Decrypt(
           API_ID_PPP_CONTENT_DECRYPTOR_PRIVATE,
           instance,
           buffer,
           serialized_block_info)));
 }
 
 PP_Bool DecryptAndDecode(PP_Instance instance,
                          PP_Resource encrypted_block,
                          const PP_EncryptedBlockInfo* encrypted_block_info) {

[dmichael (off chromium), 2012/09/05 17:13:06]

You'll have to do the same here (and other places you send a Buffer, if any).

[Tom Finegan, 2012/09/05 19:21:43]

Done.

   HostDispatcher* dispatcher = HostDispatcher::GetForInstance(instance);
   if (!dispatcher) {
     NOTREACHED();
     return PP_FALSE;
   }
 
   HostResource host_resource;
   host_resource.SetHostResource(instance, encrypted_block);
 
   uint32_t size = 0;
@@ skipping 146 matching lines @@
       return;
     CallWhileUnlocked(ppp_decryptor_impl_->DecryptAndDecode,
                       instance,
                       plugin_resource,
                       const_cast<const PP_EncryptedBlockInfo*>(&block_info));
   }
 }
 
 }  // namespace proxy
 }  // namespace ppapi