Improve existing lock transition - remove black splash.

ash/wm/power_button_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_POWER_BUTTON_CONTROLLER_H_
 #define ASH_WM_POWER_BUTTON_CONTROLLER_H_
 
 #include "ash/ash_export.h"
 #include "ash/shell_observer.h"
 #include "base/basictypes.h"
@@ skipping 39 matching lines @@
     ANIMATION_FAST_CLOSE,
     ANIMATION_FADE_IN,
     ANIMATION_HIDE,
     ANIMATION_RESTORE,
   };
 
   // Groups of containers that can be animated.
   // Exposed here for TestApi::ContainerGroupIsAnimated().
   enum ContainerGroup {
     ALL_CONTAINERS = 0,
-    SCREEN_LOCKER_CONTAINERS,
+    SCREEN_LOCKER_CONTAINERS_EXCEPT_WALLPAPER,

[Daniel Erat, 2012/08/30 16:04:53]

I find this confusing.  The containers that each enum referred to was formerly
obvious:

ALL_CONTAINERS:
  kShellWindowId_NonLockScreenContainersContainer
  kShellWindowId_LockScreenContainersContainer
  kShellWindowId_LockScreenRelatedContainersContainer
SCREEN_LOCKER_CONTAINERS:
  kShellWindowId_LockScreenContainersContainer
SCREEN_LOCKER_AND_RELATED_CONTAINERS:
  kShellWindowId_LockScreenContainersContainer
  kShellWindowId_LockScreenRelatedContainersContainer
ALL_BUT_SCREEN_LOCKER_AND_RELATED_CONTAINERS:
  kShellWindowId_NonLockScreenContainersContainer

Just from looking at the enum names now, though, I have no idea which containers
are included in each.

Maybe it'd be better to make a bitmap instead so it's clear from the code which
containers are being affected (we'll end up with very long enum names,
otherwise):

  const int kNonLockScreenContainersMask = 1 << 0;
  const int kLockScreenContainersMask    = 1 << 1;
  // etc.

  StartAnimation(
      kLockScreenWallpaperMask |
      kLockScreenContainersMask |
      kLockScreenRelatedContainersMask,
      ANIMATION_HIDE);

[Nikita (slow), 2012/08/30 17:04:51]

Are you proposing to abandon those predefined groups completely?

[Daniel Erat, 2012/08/30 17:08:43]

Yes, if the concepts of which containers each group contains become so
complicated that they can't be described in fewer than 80 characters.

[Denis Kuznetsov (DE-MUC), 2012/08/30 17:15:04]

I think exclusion-based name like "non-something" or "all but something" are a
bit confusing - we just need some good term for containers with "user" windows -
ones we are hiding when locking screen. 

As for bitmaps, I find them confusing. With group constants, we have have just 4
possible outcomes, with bitmaps there would be at least 2^3 ("session" group,
"locked" group, "background") combinations -- harder to manage and test.

I think it's better to keep with enum, but rename constants to make them
clearer.

[Nikita (slow), 2012/09/03 14:50:59]

Done.

     SCREEN_LOCKER_AND_RELATED_CONTAINERS,
     ALL_BUT_SCREEN_LOCKER_AND_RELATED_CONTAINERS,
   };
 
   // Helper class used by tests to access internal state.
   class ASH_EXPORT TestApi {
    public:
     explicit TestApi(PowerButtonController* controller)
         : controller_(controller) {}
 
@@ skipping 184 matching lines @@
   // |background_layer_|, as the desktop background is now covering the whole
   // screen.
   base::OneShotTimer<PowerButtonController> hide_background_layer_timer_;
 
   DISALLOW_COPY_AND_ASSIGN(PowerButtonController);
 };
 
 }  // namespace ash
 
 #endif  // ASH_WM_POWER_BUTTON_CONTROLLER_H_