[Chrome OS] Construct device label and unique id using vendor and product details.

[Chrome OS] Construct device label and unique id using vendor and product details.

If the device uuid is unavailable, construct the unique id using vendor id and product id values.
If the device label is unavailable, construct the name using vendor and product names.

BUG=none
TEST=none
TBR=satorux@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157089

[vandebo (ex-Chrome), 2012-09-16 19:38:45]

LGTM

http://codereview.chromium.org/10908277/diff/5002/chrome/browser/system_monit...
File chrome/browser/system_monitor/removable_device_notifications_chromeos.cc
(right):

http://codereview.chromium.org/10908277/diff/5002/chrome/browser/system_monit...
chrome/browser/system_monitor/removable_device_notifications_chromeos.cc:28:
std::string device_label = disk.device_label();
nit: device_label -> device_name or name

[kmadhusu, 2012-09-16 20:08:59]

https://codereview.chromium.org/10908277/diff/5002/chrome/browser/system_moni...
File chrome/browser/system_monitor/removable_device_notifications_chromeos.cc
(right):

https://codereview.chromium.org/10908277/diff/5002/chrome/browser/system_moni...
chrome/browser/system_monitor/removable_device_notifications_chromeos.cc:28:
std::string device_label = disk.device_label();
On 2012/09/16 19:38:45, vandebo wrote:
> nit: device_label -> device_name or name

device_label -> device_name. Done

[kmadhusu, 2012-09-16 20:11:53]

TBR'ing satorux@ to do the owner's check for chromeos files. Since the changes
are trivial, I am proceeding with the commit process. I will be happy to address
your review comments (if any) in a separate CL.  PTAL.

Thanks.

[commit-bot: I haz the power, 2012-09-16 20:12:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/10908277/11001

[commit-bot: I haz the power, 2012-09-16 22:48:01]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-16 23:16:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/10908277/11001

[commit-bot: I haz the power, 2012-09-17 00:10:26]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-17 06:03:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/10908277/11001

[commit-bot: I haz the power, 2012-09-17 07:41:45]

Change committed as 157089