chrome/browser/extensions/api/tabs/tabs.cc - Issue 10908153: [Panel refactor] Deprecate old panels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs.cc

Issue 10908153: [Panel refactor] Deprecate old panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix views compile, no need to delete extra mac menu items cuz not using browser command updater any… Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/tabs/tabs.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs.cc b/chrome/browser/extensions/api/tabs/tabs.cc

index 76e34a9457aa662f87da24916567364207f69aed..f292dda7d5f01cebcc22c7536f0a673662c07971 100644

--- a/chrome/browser/extensions/api/tabs/tabs.cc

+++ b/chrome/browser/extensions/api/tabs/tabs.cc

@@ -577,8 +577,7 @@ bool CreateWindowFunction::RunImpl() {

}

#if !defined(USE_ASH)

- if (window_type == Browser::TYPE_PANEL &&

- PanelManager::UseBrowserlessPanels()) {

+ if (window_type == Browser::TYPE_PANEL) {

std::string title =

web_app::GenerateApplicationNameFromExtensionId(extension_id);

// Note: Panels ignore all but the first url provided.

@@ -596,7 +595,6 @@ bool CreateWindowFunction::RunImpl() {

GetExtension()));

return true;

}

- // else fall through to create BrowserWindow

#endif

// Create a new BrowserWindow.