(abandoned) Validator tests: convert hexes to TFs and run on bots (for prod. validator only)

src/trusted/validator/x86/testing/tf/build.scons

+# -*- python -*-
+# Copyright (c) 2012 The Native Client Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import glob
+
+Import('env')
+
+
+if not env.Bit('target_x86'):
+  Return()
+
+tf_tests_dir = '$MAIN_DIR/src/trusted/validator/x86/testing/tf/converted'
+
+bits = int(env.get('TARGET_SUBARCH'))
+
+tf_wildcard = '%s/%s/*.tf' % (tf_tests_dir, bits)
+tfs = glob.glob(tf_wildcard)
+
+ncval = '$STAGING_DIR/ncval$PROGSUFFIX'
+
+(annotate,) = env.Command(

[Mark Seaborn, 2012/09/10 19:38:06]

Please use AutoDepsCommand() instead.  Then it will track dependencies for you
automatically, and you can write something like:

AutoDepsCommand(..., ['${PYTHON}', env.File('annotate_ty.py'), '--ncval', ncval,
...)

[Vlad Shcherbina, 2012/09/11 14:26:00]

Done.

+    target='tf_annotate.out',
+    source=['annotate_tf.py', ncval] + tfs,
+    action=[
+        'python ${SOURCES[0]} '
+        '--validator nc '
+        '--ncval%s=${SOURCES[1]} '
+        '--rdfaval=${SOURCES[2]} '
+        '--check "%s"' % (bits, tf_wildcard)

[Mark Seaborn, 2012/09/10 19:38:06]

Passing a wildcard as a command line argument is strange, especially as you're
setting "tfs" (expanded) as "source".

Please either:
 1) pass the full list here (but this might hit command line length limits)
 2) pass a directory name and have the script search the directory

[Vlad Shcherbina, 2012/09/11 14:26:00]

Explicit list of files perhaps has some advantages, but you mentioned limits
yourself (iirc, it's 2k for older versions of windows).
And why passing 'whatever_dir/32/' is better than 'whatever_dir/32/*.tf'? On the
other hand, wildcards offer additional flexibility (for instance, script can be
run on a single file).

It would make sense if scons was able to track directory dependencies, but
alas...

I'll leave it unless you object.

+    ],
+)
+
+env.AlwaysBuild(env.Alias('validator_tf_test', [annotate]))

[Mark Seaborn, 2012/09/10 19:38:06]

You should be using AddNodeToTestSuite() to add this to small_tests.

[Vlad Shcherbina, 2012/09/11 14:26:00]

Done.