src/trusted/validator_x86/testdata/64/direct-cond-jump-16.tf - Issue 10908137: (abandoned) Validator tests: convert hexes to TFs and run on bots (for prod. validator only)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/validator_x86/testdata/64/direct-cond-jump-16.tf

Issue 10908137: (abandoned) Validator tests: convert hexes to TFs and run on bots (for prod. validator only) (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: restore 'read overflow' and 'SegmentationError' Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« src/trusted/validator/x86/testing/tf/tf.py ('K') | « src/trusted/validator_x86/testdata/64/direct-call-32.tf ('k') | src/trusted/validator_x86/testdata/64/direct-cond-jump-32.tf » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	1 BITS: 64

	2 OUTCOME: invalid

	3

1 # This file tests how we handle a 16-bit conditional direct jump. In particular,	4 # This file tests how we handle a 16-bit conditional direct jump. In particular,

2 # it tests whether we actually disallow prefix 66 on direct jumps.	5 # it tests whether we actually disallow prefix 66 on direct jumps.

3 #	6 #

4 # Define direct (16-bit) conditional jump, which NaCl doesn't allow	7 # Define direct (16-bit) conditional jump, which NaCl doesn't allow

5 66 0f 84 05 00	8 hex: 66 0f 84 05 00

	9 nc_out: ERROR: Opcode sequence doesn't define a valid x86 instruction

	10 nc_out: ERROR: Use of DATA16 (66) prefix for instruction not allowed by Native C lient

	11

6	12

7 # Padding in case the parser of the previous instruction recognizes	13 # Padding in case the parser of the previous instruction recognizes

8 # the wrong byte length for the jump constant.	14 # the wrong byte length for the jump constant.

9 90 90 90	15 asm: nop; nop; nop

	16 hex: 90 90 90

	17

OLD	NEW